starlingx
/
nfv
Code Issues Proposed changes

Update patch set 13 

Patch Set 13:

(6 comments)

Patch-set: 13
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
This commit is contained in:
Gerrit User 35748 2024-04-10 12:18:27 +00:00 committed by Gerrit Code Review
parent f9c149bcbf
commit 33d23ba1eb
3 changed files with 108 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
42bd0bacf2a83108d50adc7feb000410012bafd2
View File

@ -16,6 +16,24 @@
"message": "this else (line 2166) will result in nfvi_alarm always being appended even when _ignore_alarms_conditional[] condition isnt being met ?",
"revId": "42bd0bacf2a83108d50adc7feb000410012bafd2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1593df67_29c48e0e",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 10
},
"lineNbr": 2167,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "yes, this is to ensure the alarms are waiting in a loop to clear.",
"parentUuid": "2b828b91_78096512",
"revId": "42bd0bacf2a83108d50adc7feb000410012bafd2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
],
"submitRequirementResults": [

72
9f8096d129750ad3e244ea668f16496db05a1d1a
View File

@ -35,6 +35,24 @@
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8bc59a3a_51be25aa",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 9,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "a58b25fd_3e11b029",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -175,6 +193,24 @@
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "cf3fc233_82734406",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2162,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "97a7602d_3051442f",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -210,6 +246,24 @@
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "976dc334_e3e4f9eb",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2165,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "60bb5074_d0ea55e5",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -244,6 +298,24 @@
"parentUuid": "5f8187d7_56d038dd",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6ba1777c_f1a7eb01",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 4
},
"lineNbr": 2179,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "e19db8c2_0567f2ae",
"revId": "9f8096d129750ad3e244ea668f16496db05a1d1a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
f71e226f5175572897ba6e734b9c5135730a01ed
View File

@ -70,6 +70,24 @@
"revId": "f71e226f5175572897ba6e734b9c5135730a01ed",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "012c8ed5_1a0eccd7",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 22,
"author": {
"id": 35748
},
"writtenOn": "2024-04-10T12:18:27Z",
"side": 1,
"message": "Done",
"parentUuid": "7f392cef_52d43ce7",
"revId": "f71e226f5175572897ba6e734b9c5135730a01ed",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {