starlingx
/
nfv
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(2 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9926\u003e replied on the change"}
This commit is contained in:
Gerrit User 9926 2024-03-08 19:11:55 +00:00 committed by Gerrit Code Review
parent 35585486bd
commit 4026d814bd
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
4e033e0c836d5a79c64e6ce91ef2c981990c018a Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "80902446_6939d81e",
"filename": "nfv/nfv-vim/nfv_vim/directors/_sw_mgmt_director.py",
"patchSetId": 11
},
"lineNbr": 21,
"author": {
"id": 9926
},
"writtenOn": "2024-03-08T19:11:55Z",
"side": 1,
"message": "see other comment in https://review.opendev.org/c/starlingx/nfv/+/909136/11/nfv/nfv-vim/nfv_vim/events/_vim_sw_update_api_events.py\n\n(also constants are normally CAPITALIZED)",
"range": {
"startLine": 21,
"startChar": 0,
"endLine": 21,
"endChar": 17
},
"revId": "4e033e0c836d5a79c64e6ce91ef2c981990c018a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3557cfbe_873e0e0a",
"filename": "nfv/nfv-vim/nfv_vim/events/_vim_sw_update_api_events.py",
"patchSetId": 11
},
"lineNbr": 374,
"author": {
"id": 9926
},
"writtenOn": "2024-03-08T19:11:55Z",
"side": 1,
"message": "this should be a defined constant. Could this not define and reference objects.SW_UPDATE_TYPE.CURRENT_STRATEGY ?\n\nsee: \nhttps://opendev.org/starlingx/nfv/src/branch/master/nfv/nfv-vim/nfv_vim/objects/__init__.py\n\nhttps://opendev.org/starlingx/nfv/src/branch/master/nfv/nfv-vim/nfv_vim/objects/_sw_update.py#L26",
"range": {
"startLine": 374,
"startChar": 25,
"endLine": 374,
"endChar": 43
},
"revId": "4e033e0c836d5a79c64e6ce91ef2c981990c018a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}