starlingx
/
nfv
Code Issues Proposed changes

Merge "Unsuppress pylint E1111 assignment-from-no-return"

This commit is contained in:
Zuul 2023-02-17 20:42:49 +00:00 committed by Gerrit Code Review
parent 94321e9d57 d42b8694d1
commit 7c0853eb4a
3 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
nfv/nfv-plugins/nfv_plugins/nfvi_plugins/clients/kubernetes_client.py
View File

@ -29,11 +29,8 @@ DLOG = debug.debug_get_logger('nfv_plugins.nfvi_plugins.clients.kubernetes_clien
# in the python Kubernetes client to bypass the "none image"
# check because the error is not from kubernetes.
#
# This workaround should be removed if the proposed solutions
# can be made in kubernetes or a workaround can be implemented
# in containerd.
# https://github.com/kubernetes/kubernetes/pull/79018
# https://github.com/containerd/containerd/issues/4771
# This workaround should be removed when we update to
# kubernetes client v22
def names(self, names):
"""Monkey patch V1ContainerImage with this to set the names."""
self._names = names
@ -41,7 +38,7 @@ def names(self, names):
# Replacing address of "names" in V1ContainerImage
# with the "names" defined above
V1ContainerImage.names = V1ContainerImage.names.setter(names) # pylint: disable=no-member
V1ContainerImage.names = V1ContainerImage.names.setter(names) # pylint: disable=assignment-from-no-return
def get_client():

2
nfv/nfv-tests/nfv_unit_tests/tests/test_debug_config.py
View File

@ -46,5 +46,5 @@ class TestDebugConfig(testcase.NFVTestCase):
self.assertEqual(Debug()._debug_level, DEBUG_LEVEL.VERBOSE)
# call reload_config to undo the local modification
config = debug.debug_reload_config()
debug.debug_reload_config()
self.assertNotEqual(Debug()._debug_level, DEBUG_LEVEL.VERBOSE)

6
nfv/pylint.rc
View File

@ -100,7 +100,6 @@ disable=
W0237, # arguments-renamed
W4905, # deprecated-decorator
E1101, # no-member
E1111, # assignment-from-no-return
E1121 # too-many-function-args
[REPORTS]
@ -277,6 +276,5 @@ valid-classmethod-first-arg=cls
[EXCEPTIONS]
# Exceptions that will emit a warning when being caught. Defaults to
# "Exception"
overgeneral-exceptions=Exception
# Exceptions that will emit a warning when caught.
overgeneral-exceptions=builtins.BaseException,builtins.Exception