starlingx
/
nfv
Code Issues Proposed changes
nfv/748c9090fe85301cc32cf25d783...

380 lines
12 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e8ead83e_48e88f08",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 2
},
"lineNbr": 60,
"author": {
"id": 9926
},
"writtenOn": "2024-04-22T16:06:08Z",
"side": 1,
"message": "a TODO should be added to reduce this when the software-api is async for patch release",
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ae30fb76_dcfb3e5b",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 2
},
"lineNbr": 60,
"author": {
"id": 35148
},
"writtenOn": "2024-04-22T16:08:03Z",
"side": 1,
"message": "The change in config.ini should be enough, this default shouldn\u0027t be changed.",
"range": {
"startLine": 60,
"startChar": 0,
"endLine": 60,
"endChar": 33
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0ee300a8_c8e9926d",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 2
},
"lineNbr": 60,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "changing in config.ini takes effect on the usm plugin timeout, but the thread that\nruns the task ends if the timeout is not changed here.",
"parentUuid": "ae30fb76_dcfb3e5b",
"range": {
"startLine": 60,
"startChar": 0,
"endLine": 60,
"endChar": 33
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "832f860a_3a886903",
"filename": "nfv/nfv-common/nfv_common/tasks/_task_future.py",
"patchSetId": 2
},
"lineNbr": 60,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "e8ead83e_48e88f08",
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d02d76ab_8362a14f",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 2
},
"lineNbr": 2363,
"author": {
"id": 35148
},
"writtenOn": "2024-04-22T16:08:03Z",
"side": 1,
"message": "TODO?",
"range": {
"startLine": 2354,
"startChar": 1,
"endLine": 2363,
"endChar": 54
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c3a9b272_3b877003",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/nfvi_infrastructure_api.py",
"patchSetId": 2
},
"lineNbr": 2363,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "added todo comment.\nobject update is not done here, as the api will be changed to asynch call.\nthe object update could be done as part of api \u0027deploy show\u0027 to check on the state and release data in event handling and callback function of start.",
"parentUuid": "d02d76ab_8362a14f",
"range": {
"startLine": 2354,
"startChar": 1,
"endLine": 2363,
"endChar": 54
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "303ad34c_303cf887",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/rest_api.py",
"patchSetId": 2
},
"lineNbr": 476,
"author": {
"id": 35148
},
"writtenOn": "2024-04-22T16:08:03Z",
"side": 1,
"message": "This shouldn\u0027t need to be changed since you changed the timeout in \nnfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/usm.py?\n\nIf this one gets changed you technically should test every strategy...",
"range": {
"startLine": 476,
"startChar": 21,
"endLine": 476,
"endChar": 41
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c7c78a3a_dfcbf2ec",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/rest_api.py",
"patchSetId": 2
},
"lineNbr": 476,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "Tested k8s upgrade with this change, seems to work fine.\nI guess the timeout in each plugin call is replacing the value 600.\nIn such case the same should be the behavior of sw-deploy-strategy.\ntodo: test sw-deploy-strategy with only change in usm timeout.\n\nStrategy Kubernetes Upgrade Strategy:\n strategy-uuid: 2a85655e-62cd-40c0-b67e-9df79c68418a\n controller-apply-type: serial\n storage-apply-type: serial\n worker-apply-type: serial\n default-instance-action: stop-start\n alarm-restrictions: strict\n current-phase: apply\n current-phase-completion: 100%\n state: applied",
"parentUuid": "303ad34c_303cf887",
"range": {
"startLine": 476,
"startChar": 21,
"endLine": 476,
"endChar": 41
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "be1ad2f8_db2c916f",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/usm.py",
"patchSetId": 2
},
"lineNbr": 91,
"author": {
"id": 9926
},
"writtenOn": "2024-04-22T16:06:08Z",
"side": 1,
"message": "the region_name is a variable, so cannot assume a region_name\n\nPlease verify with subcloud deployment; and/or this review https://review.opendev.org/c/starlingx/ansible-playbooks/+/916310 and it\u0027s 3 Depends-On dependencies",
"range": {
"startLine": 91,
"startChar": 44,
"endLine": 91,
"endChar": 67
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "77e931bc_34b9c7e5",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/usm.py",
"patchSetId": 2
},
"lineNbr": 91,
"author": {
"id": 9926
},
"writtenOn": "2024-04-22T16:10:43Z",
"side": 1,
"message": "It should also be noted, that when running on the system, the region name can be determined from https://review.opendev.org/c/starlingx/config/+/915755 (v1/isystems/region_id ; and extracting the required field)",
"parentUuid": "be1ad2f8_db2c916f",
"range": {
"startLine": 91,
"startChar": 44,
"endLine": 91,
"endChar": 67
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e5c76e02_3bcac169",
"filename": "nfv/nfv-plugins/nfv_plugins/nfvi_plugins/openstack/usm.py",
"patchSetId": 2
},
"lineNbr": 91,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "To adapt the precheck api call to exclude region name once the software-api changes are available.",
"parentUuid": "77e931bc_34b9c7e5",
"range": {
"startLine": 91,
"startChar": 44,
"endLine": 91,
"endChar": 67
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7b349a35_b80dd2f7",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 2
},
"lineNbr": 1840,
"author": {
"id": 35148
},
"writtenOn": "2024-04-22T16:08:03Z",
"side": 1,
"message": "This should be in the sw precheck step",
"range": {
"startLine": 1809,
"startChar": 1,
"endLine": 1840,
"endChar": 0
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "79578374_c3121653",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 2
},
"lineNbr": 1840,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "checking the response of the result-data to determine success / failure?",
"parentUuid": "7b349a35_b80dd2f7",
"range": {
"startLine": 1809,
"startChar": 1,
"endLine": 1840,
"endChar": 0
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "19fba6e7_2f72a3ba",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 2
},
"lineNbr": 1858,
"author": {
"id": 35148
},
"writtenOn": "2024-04-22T16:08:03Z",
"side": 1,
"message": "precheck should be after QueryUpgradeStep",
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9fe5aab7_6ec41609",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy.py",
"patchSetId": 2
},
"lineNbr": 1858,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "Agreed.\nQueryUpgradeStep corresponds to \u0027software list\u0027 api?\nif yes, then QueryUpgrade to be done before precheck, as we need the data to validate the \u0027input\u0027 release passed by the user and its state.",
"parentUuid": "19fba6e7_2f72a3ba",
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "83d210f1_cddc0df1",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 2
},
"lineNbr": 1122,
"author": {
"id": 35148
},
"writtenOn": "2024-04-22T16:08:03Z",
"side": 1,
"message": "Should have been response[\u0027result-data\u0027][\u0027release_info\u0027][\u0027state\u0027]",
"range": {
"startLine": 1122,
"startChar": 60,
"endLine": 1122,
"endChar": 92
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0453fa4e_0008c53a",
"filename": "nfv/nfv-vim/nfv_vim/strategy/_strategy_steps.py",
"patchSetId": 2
},
"lineNbr": 1122,
"author": {
"id": 35748
},
"writtenOn": "2024-04-25T14:00:05Z",
"side": 1,
"message": "response[\u0027result-data\u0027] is assigned with release_info data in nfvi_infrastructure_api Line #2365",
"parentUuid": "83d210f1_cddc0df1",
"range": {
"startLine": 1122,
"startChar": 60,
"endLine": 1122,
"endChar": 92
},
"revId": "748c9090fe85301cc32cf25d7830eddc8b15b7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink