Update patch set 4

Patch Set 4:

(4 comments)

Patch-set: 4
This commit is contained in:
Gerrit User 33390 2024-04-26 13:26:57 +00:00 committed by Gerrit Code Review
parent d32d5f6433
commit 777a9e1316
2 changed files with 98 additions and 0 deletions

View File

@ -23,6 +23,30 @@
"revId": "5920ed20d5e89196266dc2194355662fac4bf700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "04a1202e_6524d396",
"filename": "build-tools/stx/patch/patch_builder.py",
"patchSetId": 3
},
"lineNbr": 110,
"author": {
"id": 33390
},
"writtenOn": "2024-04-26T13:26:57Z",
"side": 1,
"message": "Done",
"parentUuid": "02e944f7_96eda762",
"range": {
"startLine": 110,
"startChar": 35,
"endLine": 110,
"endChar": 51
},
"revId": "5920ed20d5e89196266dc2194355662fac4bf700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -45,6 +69,30 @@
},
"revId": "5920ed20d5e89196266dc2194355662fac4bf700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "396f8ff7_fe0fb811",
"filename": "build-tools/stx/patch/patch_builder.py",
"patchSetId": 3
},
"lineNbr": 186,
"author": {
"id": 33390
},
"writtenOn": "2024-04-26T13:26:57Z",
"side": 1,
"message": "Done",
"parentUuid": "c01cd255_49f029a0",
"range": {
"startLine": 185,
"startChar": 8,
"endLine": 186,
"endChar": 24
},
"revId": "5920ed20d5e89196266dc2194355662fac4bf700",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8f0b3486_c4786320",
"filename": "/COMMIT_MSG",
"patchSetId": 4
},
"lineNbr": 14,
"author": {
"id": 33390
},
"writtenOn": "2024-04-26T13:26:57Z",
"side": 1,
"message": "It would be nice to have an additional Test Case, like \"Run deploy-precheck for the patch\"",
"range": {
"startLine": 14,
"startChar": 0,
"endLine": 14,
"endChar": 10
},
"revId": "e31ba3193875494d37499a91f3c6d7527754acee",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "56a49c1e_c65c3475",
"filename": "build-tools/stx/patch/patch_builder.py",
"patchSetId": 4
},
"lineNbr": 153,
"author": {
"id": 33390
},
"writtenOn": "2024-04-26T13:26:57Z",
"side": 1,
"message": "nit: additional space before \",\"",
"range": {
"startLine": 153,
"startChar": 70,
"endLine": 153,
"endChar": 73
},
"revId": "e31ba3193875494d37499a91f3c6d7527754acee",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}