starlingx
/
root
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(13 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 35166 \u003c35166@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35166\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 31683 \u003c31683@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35166\u003e replied on the change"}
This commit is contained in:
Gerrit User 35166 2024-05-13 15:38:49 +00:00 committed by Gerrit Code Review
parent 346fbd0917
commit 84d396ee10
2 changed files with 250 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

228
3effcd138280e1c70db04992c1ab87330dbed1b4
View File

@ -17,6 +17,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "19eed1df_eabae190",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "9c16cbb6_e23dfef9",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -34,6 +52,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "6b5d96bb_c421c800",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 8,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "724c3021_b9f67bbd",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +87,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "116a3f8e_000cc736",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 12,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "df283023_0fa20494",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +122,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b161227c_4a17414d",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 20,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "3ea69671_b3974f4a",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -91,6 +163,30 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "784e479f_58650410",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 25,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "c4e1195e_c926d853",
"range": {
"startLine": 22,
"startChar": 0,
"endLine": 25,
"endChar": 25
},
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -108,6 +204,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b74ecc29_d0402396",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 26,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "1daa9c39_7907abcc",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -125,6 +239,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "77b8eeb3_83336e48",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 29,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "b0dcf7e0_1bca1273",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -142,6 +274,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "473ac620_669cea06",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 30,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "f5085dc0_cac96c2c",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -159,6 +309,24 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f0e1cda4_909ab9ad",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 36,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "aa79cb63_2fb508c8",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -199,6 +367,48 @@
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dd8e86d5_5fe62a5e",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 37,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "dbd52237_5bd00c73",
"range": {
"startLine": 37,
"startChar": 23,
"endLine": 37,
"endChar": 41
},
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "584bf97a_afbd220b",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 37,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Done",
"parentUuid": "028b856e_bee08604",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -215,6 +425,24 @@
"message": "I think this should be a warning. Beginning with \"WARNING: ...\" and exiting with 0.",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9b28c5c4_28825b6a",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 2
},
"lineNbr": 39,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "Thanks for all the comments, Davlet",
"parentUuid": "2f7f795f_bd995a93",
"revId": "3effcd138280e1c70db04992c1ab87330dbed1b4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

22
50a8a95fe9ccc296505b6b0ea28aa6f6b19a295e Normal file
View File

@ -0,0 +1,22 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7609387e_598ed649",
"filename": "build-tools/build-extra-helm-charts.sh",
"patchSetId": 1
},
"lineNbr": 16,
"author": {
"id": 35166
},
"writtenOn": "2024-05-13T15:38:49Z",
"side": 1,
"message": "\u003e linters: E020 Function declaration not in format ^function name {$\n\nPlease fix.",
"parentUuid": "4e5fb547_40278626",
"revId": "50a8a95fe9ccc296505b6b0ea28aa6f6b19a295e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}