starlingx
/
root
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
This commit is contained in:
Gerrit User 33750 2024-04-11 22:32:27 +00:00 committed by Gerrit Code Review
parent 0c9fbb1755
commit b1fe6d0484
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
6330c4483548c8e8c2b1d424eba8511dea3d6718 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "3a109b5a_73a2785c",
"filename": "build-tools/stx/patch/patch_builder.py",
"patchSetId": 1
},
"lineNbr": 53,
"author": {
"id": 33750
},
"writtenOn": "2024-04-11T22:32:27Z",
"side": 1,
"message": "Does this work without defining file_name default value equal to None in the function definition?",
"range": {
"startLine": 53,
"startChar": 63,
"endLine": 53,
"endChar": 80
},
"revId": "6330c4483548c8e8c2b1d424eba8511dea3d6718",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3ab2e9f7_7a4da299",
"filename": "build-tools/stx/patch/patch_builder.py",
"patchSetId": 1
},
"lineNbr": 208,
"author": {
"id": 33750
},
"writtenOn": "2024-04-11T22:32:27Z",
"side": 1,
"message": "Does this work? Was this meant to be an \u0027\u003d\u0027?",
"range": {
"startLine": 208,
"startChar": 22,
"endLine": 208,
"endChar": 23
},
"revId": "6330c4483548c8e8c2b1d424eba8511dea3d6718",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}