starlingx
/
root
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 33394 <33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 072f3c66a416c440d9dc594d3ffdc1e38a99f4fd
Attention: {"person_ident":"Gerrit User 32651 \u003c32651@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33394\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33394 \u003c33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33394\u003e replied on the change"}
This commit is contained in:
Gerrit User 33394 2024-02-23 20:55:17 +00:00 committed by Gerrit Code Review
parent c416d825ce
commit e1af633498
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
10951dbebcd8010ff63285d12de87efd639a79e4
View File

@ -16,6 +16,23 @@
"message": "The original gpg key expired today and blocked all build progress. This commit is just disable the sign process to workaround it.\n\nTo resolve this issue later, we have two choices:\n1) Do not sign the aptly repository;\n2) Introduce a new gpg key pair.\n\nAny suggestions?",
"revId": "10951dbebcd8010ff63285d12de87efd639a79e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c0e595c4_f95d77b1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 33394
},
"writtenOn": "2024-02-23T20:55:17Z",
"side": 1,
"message": "Since we published the key and password this wasn\u0027t providing any real level of security, so removing this capability is fine. I assume there are no remaining locations in the code where we need to disable verification, if so, LGTM.",
"revId": "10951dbebcd8010ff63285d12de87efd639a79e4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}