starlingx
/
root
Code Issues Proposed changes
root/build-tools
History
Don Penney b58bd1cc5a Fix use of 'let -i' in scripts 
Unlike "declare -i" and "local -i", the bash "let" does not support a
"-i" option. Rather, it takes it as a variable reference. If no "i"
variable is defined in scope, it does not cause an issue. If "i" has
been defined somewhere, however, it may cause a syntax issue, as the i
is evaluated.

A recent update to build-stx-images.sh added a loop that defines an
"i" variable without limiting its scope. In a current image build,
this loop ends with having "i" defined as a URL. As a result, a
"syntax error in expression" occurs, causing the "with_retries"
function to fail to increment the counter. Should a build error occur,
the "with_retries" will never hit the retry limit, looping until it
has a successful result.

This update removes the -i from all "let -i" occurrences in the build
scripts.

Change-Id: I34ad49f8872a81659ff4caf8087b256ea9fb3d32
Closes-Bug: 1891189
Signed-off-by: Don Penney <don.penney@windriver.com>
(cherry picked from commit f36db7e207)
 		2020-08-13 21:57:28 +00:00
..
branching remove leading path from branch name 2020-06-17 11:02:38 -07:00
build-docker-images Add --config-file argument for docker image build script 2020-07-30 01:33:44 +00:00
build-wheels Fix use of 'let -i' in scripts 2020-08-13 21:57:28 +00:00
build_guest build-tools: Convert wrsroot -> sysadmin 2019-06-14 14:48:25 -07:00
build_iso Fix potential infinite loop in build-iso 2020-05-08 00:24:21 +00:00
build_minimal_iso build-tools: Convert wrsroot -> sysadmin 2019-06-14 14:48:25 -07:00
certificates StarlingX open source release updates 2018-06-01 07:45:23 -07:00
mirror_rebase StarlingX open source release updates 2018-06-01 07:45:23 -07:00
mk Uprev grub2 and shim 2018-06-27 13:04:02 -04:00
repo_files Update to build tools to support Build layering. 2020-02-07 16:36:40 -05:00
signing StarlingX open source release updates 2018-06-01 07:45:23 -07:00
Cached_Data.txt StarlingX open source release updates 2018-06-01 07:45:23 -07:00
audit-pkgs StarlingX open source release updates 2018-06-01 07:45:23 -07:00
build-avoidance-utils.sh Build avoidance for all build-type values 2020-03-30 16:52:13 -04:00
build-guest Prepare the build tools for code restucturing 2019-09-05 15:18:10 -04:00
build-helm-charts.sh find_chartfile returns multiple erroneous files 2020-04-20 12:14:16 -04:00
build-img Shorten "addons/wr-cgcs/layers/cgcs" to just "stx" 2018-07-04 15:12:58 -04:00
build-iso Use private yum cache dir in build scripts 2020-03-19 10:21:00 -04:00
build-pkg-srpm StarlingX open source release updates 2018-06-01 07:45:23 -07:00
build-pkgs Use private yum cache dir in build scripts 2020-03-19 10:21:00 -04:00
build-pkgs-parallel Add a dependency checker to build-pkgs 2020-06-05 18:42:21 -04:00
build-pkgs-serial Add a dependency checker to build-pkgs 2020-06-05 18:42:21 -04:00
build-remote-cli.sh Support custom docker registries for remote cli 2020-03-18 16:29:49 +02:00
build-rpms Build Avoidance 2018-09-17 16:41:31 -04:00
build-rpms-parallel Extend GITREVCOUNT to inputs other than SRC_DIR and PKG_BASE 2020-06-10 17:48:26 -04:00
build-rpms-serial Add a dependency checker to build-pkgs 2020-06-05 18:42:21 -04:00
build-srpms Build Avoidance 2018-09-17 16:41:31 -04:00
build-srpms-common.sh Extend GITREVCOUNT to inputs other than SRC_DIR and PKG_BASE 2020-06-10 17:48:26 -04:00
build-srpms-parallel Extend GITREVCOUNT to inputs other than SRC_DIR and PKG_BASE 2020-06-10 17:48:26 -04:00
build-srpms-serial Extend GITREVCOUNT to inputs other than SRC_DIR and PKG_BASE 2020-06-10 17:48:26 -04:00
classify Build: Improved logging, error handling, and other small fixes 2018-08-29 16:31:09 -04:00
create-cgcs-centos-repo StarlingX open source release updates 2018-06-01 07:45:23 -07:00
create-cgcs-tis-repo StarlingX open source release updates 2018-06-01 07:45:23 -07:00
create-yum-conf Update to build tools to support Build layering. 2020-02-07 16:36:40 -05:00
create_dependancy_cache.py Remove unused variables 2019-02-01 22:58:37 +00:00
default_build_srpm Extend GITREVCOUNT to inputs other than SRC_DIR and PKG_BASE 2020-06-10 17:48:26 -04:00
find_klm StarlingX open source release updates 2018-06-01 07:45:23 -07:00
find_patched_srpms_needing_upgrade StarlingX open source release updates 2018-06-01 07:45:23 -07:00
git-repo-utils.sh use single '=' for string equality in repo forall 2020-06-16 11:44:44 -07:00
git-utils.sh Extend GITREVCOUNT to inputs other than SRC_DIR and PKG_BASE 2020-06-10 17:48:26 -04:00
image-utils.sh Update to build tools to support Build layering. 2020-02-07 16:36:40 -05:00
ip_report.py Python 3 compatibility: use print as a function. 2018-10-12 13:42:44 +00:00
make-installer-images.sh Add lz4 to squashfs img and clean unused rpm 2018-09-18 18:28:42 +08:00
mock_cfg_to_yum_conf.py Python 3 compatibility: use print as a function. 2018-10-12 13:42:44 +00:00
mockchain-parallel Update mockchain-parallel wrapper for mock-1.4.20 2019-10-21 13:26:42 -04:00
mockchain-parallel-1.3.4 Update to build tools to support Build layering. 2020-02-07 16:36:40 -05:00
mockchain-parallel-1.4.16 Update to build tools to support Build layering. 2020-02-07 16:36:40 -05:00
modify-build-cfg Update to build tools to support Build layering. 2020-02-07 16:36:40 -05:00
patch-iso Fix use of 'let -i' in scripts 2020-08-13 21:57:28 +00:00
patch_rebase_1 Prepare the build tools for code restucturing 2019-09-05 15:18:10 -04:00
patch_rebase_2 Prepare the build tools for code restucturing 2019-09-05 15:18:10 -04:00
patch_rebase_3 Prepare the build tools for code restucturing 2019-09-05 15:18:10 -04:00
patch_rebase_4 Prepare the build tools for code restucturing 2019-09-05 15:18:10 -04:00
repo-utils.sh use single '=' for string equality in repo forall 2020-06-16 11:44:44 -07:00
sign-rpms Prepare the build tools for code restucturing 2019-09-05 15:18:10 -04:00
sign-secure-boot Build Avoidance 2018-09-17 16:41:31 -04:00
sign_iso_formal.sh cleanup signing scripts 2018-09-07 14:44:37 -04:00
sign_patch_formal.sh cleanup signing scripts 2018-09-07 14:44:37 -04:00
source_lookup.txt Drop smartpm reference from source_lookup.txt 2020-01-15 23:46:00 -05:00
spec-utils enable pbr version 2020-06-08 16:54:14 +08:00
srpm-utils Fix use of 'let -i' in scripts 2020-08-13 21:57:28 +00:00
stxRpmUtils.py Correct build failure after mock updrade 2019-06-06 13:39:34 -04:00
sync-jenkins StarlingX open source release updates 2018-06-01 07:45:23 -07:00
sync_jenkins.sh Fix linters issues and enable tox/zuul linters job as gate 2018-09-05 22:42:11 +08:00
tis.macros StarlingX open source release updates 2018-06-01 07:45:23 -07:00
update-efiboot-image Prepare the build tools for code restucturing 2019-09-05 15:18:10 -04:00
update-pxe-network-installer Remove tpm from update-pxe-network-installer script 2020-05-14 09:22:19 +08:00
wheel-utils.sh Enable build of docker images, charts and wheels from a layered build 2020-04-08 13:58:41 -04:00
wrs_orig.txt StarlingX open source release updates 2018-06-01 07:45:23 -07:00