starlingx
/
specs
Code Issues Proposed changes

Update patch set 22 

Patch Set 22: Code-Review-1

(2 comments)

Patch-set: 22
Label: Code-Review=-1, be8c5a89fad8777eb49b970936f5da25449697d1
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33265 \u003c33265@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2023-06-09 21:45:46 +00:00 committed by Gerrit Code Review
parent 085f0c6af2
commit 4cc98af95e
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
b3e3cc575c8f446092b1515da151e444d070f26b
View File

@ -264,6 +264,24 @@
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "48b65330_7a743d55",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
"patchSetId": 22
},
"lineNbr": 354,
"author": {
"id": 8768
},
"writtenOn": "2023-06-09T21:45:46Z",
"side": 1,
"message": "In many cases it\u0027s sufficient to test AIO-SX and Standard since this tests simplex (which special-cases things), AIO generally, standalone controllers, and standalone workers.\n\nPower management shouldn\u0027t behave differently for AIO-DX and DC systems.",
"parentUuid": "b435862c_b102f830",
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -297,6 +315,24 @@
"message": "Do we need an upgrade test to verify the impact of deprecating existing Host CPU MHz parameters?",
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d2d3c1ff_e3bfcbe4",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
"patchSetId": 22
},
"lineNbr": 366,
"author": {
"id": 8768
},
"writtenOn": "2023-06-09T21:45:46Z",
"side": 1,
"message": "Yes. Need to test the behaviour when legacy parameters are already set.",
"parentUuid": "69c5359b_b0cc013a",
"revId": "b3e3cc575c8f446092b1515da151e444d070f26b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}