Update patch set 19
Patch Set 19: (3 comments) Patch-set: 19
This commit is contained in:
parent
5256f80812
commit
5dd5aee1ff
|
@ -0,0 +1,73 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "83e15075_c6841344",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 19
|
||||
},
|
||||
"lineNbr": 180,
|
||||
"author": {
|
||||
"id": 8768
|
||||
},
|
||||
"writtenOn": "2023-05-30T19:43:37Z",
|
||||
"side": 1,
|
||||
"message": "nit: Kubernetes will assign individual logical CPUs (not cores) to each application container, possibly SMT siblings but not necessarily. And there may be more than one logical CPU assigned to the application Pod.\n\nSo maybe change this to \"cpu(s) assigned by Kubernetes to the Pod\"?",
|
||||
"range": {
|
||||
"startLine": 180,
|
||||
"startChar": 3,
|
||||
"endLine": 180,
|
||||
"endChar": 8
|
||||
},
|
||||
"revId": "39052d850badc745b34097702eafe82809c88f3a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "91acc196_3c07b442",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 19
|
||||
},
|
||||
"lineNbr": 205,
|
||||
"author": {
|
||||
"id": 8768
|
||||
},
|
||||
"writtenOn": "2023-05-30T19:43:37Z",
|
||||
"side": 1,
|
||||
"message": "Presumably this will only be removed if the Kubernetes Power Manager is enabled for a given node? Will the puppet code be made conditional based on whether the new label is set on the given node?",
|
||||
"range": {
|
||||
"startLine": 205,
|
||||
"startChar": 58,
|
||||
"endLine": 205,
|
||||
"endChar": 74
|
||||
},
|
||||
"revId": "39052d850badc745b34097702eafe82809c88f3a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0322e5fe_78db1cf9",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
|
||||
"patchSetId": 19
|
||||
},
|
||||
"lineNbr": 234,
|
||||
"author": {
|
||||
"id": 8768
|
||||
},
|
||||
"writtenOn": "2023-05-30T19:43:37Z",
|
||||
"side": 1,
|
||||
"message": "Do we want to silently ignore the legacy settings, or do semantic checks to prevent the Kubernetes Power Manager from being enabled if the legacy settings are set (and vice versa)?",
|
||||
"range": {
|
||||
"startLine": 234,
|
||||
"startChar": 33,
|
||||
"endLine": 234,
|
||||
"endChar": 73
|
||||
},
|
||||
"revId": "39052d850badc745b34097702eafe82809c88f3a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue