Update patch set 1
Patch Set 1:
(7 comments)
Patch-set: 1
Attention: {"person_ident":"Gerrit User 33377 \u003c33377@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33377\u003e replied on the change"}
This commit is contained in:
Gerrit User 33377
Gerrit Code Review
parent
7d16e233a0
commit
7fdbd464d3
|
|
@ -16,6 +16,149 @@
|
|||
"message": "Is this really being done in stx-9.0 (March/2024) ?\n\nor stx-10.0 (September/2024) ? ... if september, then should move it to the stx-10 folder.",
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "2fcb778c_8cbb409f",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-01-04T23:02:52Z",
|
||||
"side": 1,
|
||||
"message": "Hi Li,\n\nThanks for taking this on and inviting me to the review!\n\nThis is a good start. I ran out of review time today, but I still wanted to publish my partial comments so that we can discuss them earlier, if you would like.\n\nI will continue my review tomorrow.\n\nThanks again,\n\nVefa",
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "37fb32e4_0488d32a",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 13,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-01-04T23:02:52Z",
|
||||
"side": 1,
|
||||
"message": "Suggest minor rewording:\n\n```\nWe would like to align the StarlingX kernel to the latest long-term support\nversion available in linux-yocto (v6.6.y), so that StarlingX can take advantage\nof upstream improvements that have been made since the current StarlingX kernel\n(v5.10.y).\n\nTo-be-confirmed: In addition, we would like to migrate from a number of\nout-of-tree device drivers to their in-tree counterparts.\n```",
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "47e40917_81144f6c",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 19,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-01-04T23:02:52Z",
|
||||
"side": 1,
|
||||
"message": "Suggested rewording:\n\n```\nStarlingX currently has kernel version 5.10, while the latest long-term\nsupport (LTS) version available as of this writing is 6.6 according to [1]_.\nWe would like to align the StarlingX kernel with version 6.6, with the\nfollowing rationale:\n\n* Reason 1: ...\n* Reason 2: ...\n* Reason 3: ...\n\nIn addition, StarlingX currently ships with a number of out-of-tree device\ndrivers, such as ice, i40e, iavf, ... and ... . We would like to migrate from\nthese out-of-tree drivers to their in-tree counterparts due to the following\nreasons:\n\n* Reason 1: Improved maintainability with the ability to cherry-pick bug-fix\n changes from the mainline kernel releases as opposed to having access to\n opaque tar archive releases only.\n* Reason 2: ...\n* Reason 3: ...\n\n\nReferences:\n.. [1] https://www.kernel.org/releases.html\n```\n\nIt would be helpful to list a few improvements that we have in mind as a rationale for the kernel uprevision. As an example, for the v5.10 kernel, the VRF feature (if I recall correctly) was an important feature:\n\nhttps://opendev.org/starlingx/specs/src/commit/6f16a60855661b0468eb40f8ce50b68f51d10e69/doc/source/specs/stx-6.0/approved/os_2008921_kernel_v510.rst\n\nI need to think a bit about potential examples, but the kernelnewbies.org LinuxVersions page has very good summaries of the features and improvements introduced by every kernel release:\n\nhttps://kernelnewbies.org/LinuxVersions\n\nWe can discuss the rationales for the kernel uprevision internally as well.",
|
||||
"range": {
|
||||
"startLine": 18,
|
||||
"startChar": 0,
|
||||
"endLine": 19,
|
||||
"endChar": 2
|
||||
},
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "4e48ff62_26ea9353",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 23,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-01-04T23:02:52Z",
|
||||
"side": 1,
|
||||
"message": "This section is intended to explain the use cases of stakeholders (such as developers, end users and deployers) that will be enabled by this proposed feature and the potential impacts to the stakeholders\u0027 use-cases/workflows. Here is a description from: https://opendev.org/starlingx/specs/src/commit/6f16a60855661b0468eb40f8ce50b68f51d10e69/specs/2019.03/approved/STX_Example_Spec.rst\n\n```\nUse Cases\n\nWhat use cases does this address? What impact on actors does this change have?\nEnsure you are clear about the actors/personas in each use case: Developer,\nEnd User, Deployer etc.\n```\n\n----\n\nHere is a suggested starter draft, similar to the one for the v5.10 kernel:\n\n```\nThe uprevision to the 6.6 kernel is expected to introduce new use cases such as\nX, Y and Z, which are enabled by the features and improvements discussed above:\n\n* Use case X: ...\n* Use case Y: ...\n* Use case Z: ...\n\nIn terms of impacts of the kernel uprevision:\n\n* End users: The kernel uprevision should be transparent to the current use cases\n of end users, thanks to the kernel\u0027s stable user-space ABI. \n \n* Developers: During this kernel uprevision, StarlingX kernel maintainers\u0027\n workflows will be improved by migrating the kernel package changelog and\n the kernel configuration from patch files to regular files in the kernel\n packaging repository (starlingx/kernel).\n\n* Developers: Higher-level components in StarlingX are not expected to be \n impacted, but changes to kernel interfaces such as the kernel command line,\n and the procfs and sysfs file systems may require modifications to the\n StarlingX installer, Ansible playbooks and other system configuration tooling.\n \n* Deployers: As with the impacts to the developers of StarlingX\u0027s higher-level\n components, there may be slight impacts to the deployers of StarlingX due to\n potential changes to the kernel interfaces mentioned above, in case deployers\n are customizing the kernel\u0027s run-time settings.\n \n\nIn terms of the migration from out-of-tree drivers to in-tree drivers:\n\n* End users: Different (more or less) features available in in-tree drivers?\n\n* Kernel developers: Reduction of packaging work ...\n\n* Other Developers: Little to no impact?\n\n* Deployers: ...\n```\n\nWe can then explain the \"other\" impacts in the sections below.",
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7ce2b0ea_954d9163",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 40,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-01-04T23:02:52Z",
|
||||
"side": 1,
|
||||
"message": "Minor:\n\nSince we are referring to the repository rather than a specific branch, we can use this link:\n\nhttps://salsa.debian.org/kernel-team/linux\n\n\n---\n\nIn addition, it would be good to make these links proper references. Please see the v5.10 kernel specification document\u0027s source code as an example:\n\nhttps://opendev.org/starlingx/specs/raw/commit/6f16a60855661b0468eb40f8ce50b68f51d10e69/doc/source/specs/stx-6.0/approved/os_2008921_kernel_v510.rst\n\nExample excerpt:\n\n```\nAccording to the CentOS stream announcement [2]_, updates of CentOS 8 will\nterminate at the end of 2021. With STX 6.0 scheduled to be released in mid\nDecember 2021 [3]_ this would leave the release containing a kernel with an\nuncertain future, just weeks after the STX 6.0 release.\n\n.. [1] https://lwn.net/Articles/430098/\n.. [2] https://blog.centos.org/2020/12/future-is-centos-stream/\n.. [3] https://docs.google.com/spreadsheets/d/13p0BMlBgJXUVForOFsblAJq9jA1-FMBlmhV5TIc70IE\n\n```",
|
||||
"range": {
|
||||
"startLine": 40,
|
||||
"startChar": 0,
|
||||
"endLine": 40,
|
||||
"endChar": 71
|
||||
},
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "edb799f7_81bc47bc",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 47,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-01-04T23:02:52Z",
|
||||
"side": 1,
|
||||
"message": "It would be good to refer to StarlingX end users and deployers instead of customers.",
|
||||
"range": {
|
||||
"startLine": 47,
|
||||
"startChar": 53,
|
||||
"endLine": 47,
|
||||
"endChar": 63
|
||||
},
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ed7b78e0_71d96698",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/kernel-2011000-uprevision-to-6.6.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 51,
|
||||
"author": {
|
||||
"id": 33377
|
||||
},
|
||||
"writtenOn": "2024-01-04T23:02:52Z",
|
||||
"side": 1,
|
||||
"message": "Minor: This should be a comment in the document.",
|
||||
"range": {
|
||||
"startLine": 49,
|
||||
"startChar": 39,
|
||||
"endLine": 51,
|
||||
"endChar": 29
|
||||
},
|
||||
"revId": "b612622ae079e4d93c1ba3bbb1557909338844b1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue