starlingx
/
specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 33377 \u003c33377@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33377\u003e replied on the change"}
This commit is contained in:
Gerrit User 33377 2024-01-30 21:41:48 +00:00 committed by Gerrit Code Review
parent a95920b67b
commit 8677763e20
1 changed files with 53 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
8d05288efa59f8bcf1e9230bb4e68e1abceb1268
View File

@ -281,6 +281,59 @@
"revId": "8d05288efa59f8bcf1e9230bb4e68e1abceb1268",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0b7bb13a_f538b7bd",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 33377
},
"writtenOn": "2024-01-30T21:41:48Z",
"side": 1,
"message": "Thanks!",
"parentUuid": "cfe19f34_5f4f15e8",
"revId": "8d05288efa59f8bcf1e9230bb4e68e1abceb1268",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1dd5dc05_bd4ae659",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 33377
},
"writtenOn": "2024-01-30T21:41:48Z",
"side": 1,
"message": "Hi all,\n\nI realized that I am missing a minor change. The \"placeholder\" file in the same directory as the new specification proposal document needs to be removed. ( https://opendev.org/starlingx/specs/src/branch/master/doc/source/specs/stx-10.0/approved/_placeholder.rst )\n\nWhile addressing that, I will also add a note about the potential for the v6.6 kernel to introduce issues for downstream (with respect to StarlingX) kernel module providers, due to the lack of an in-kernel stable API/ABI. This concern was raised by Mark Asselstine. (I will get offline feedback from Mark before publishing my changes, to avoid back-and-forth review comments.)\n\nAll this to say, I will publish a newer revision of this change with these two minor issues fixed, and we will be good to go!\n\nThanks again!\n\nVefa",
"revId": "8d05288efa59f8bcf1e9230bb4e68e1abceb1268",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e4c7b673_67cb515a",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 33377
},
"writtenOn": "2024-01-30T21:41:48Z",
"side": 1,
"message": "Thanks! I am happy that we addressed your concerns.\n\n(I am marking this as resolved.)",
"parentUuid": "1a94840b_2cf5a259",
"revId": "8d05288efa59f8bcf1e9230bb4e68e1abceb1268",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {