starlingx
/
specs
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(6 comments)

Thanks for all the great comments - addressed now

Patch-set: 2
Reviewer: Gerrit User 9557 <9557@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 9557 2018-10-02 14:10:19 +00:00 committed by Gerrit Code Review
parent 92fb81f203
commit 94d2ed9778
1 changed files with 114 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

114
79a8d6abf7d4e23cf62855e592834e3c48fad5a4
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_00b62e8a",
"filename": "specs/STX_Example_Spec.rst",
"patchSetId": 2
},
"lineNbr": 124,
"author": {
"id": 9557
},
"writtenOn": "2018-10-02T14:10:19Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_2f5d6747",
"revId": "79a8d6abf7d4e23cf62855e592834e3c48fad5a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_0f898bc5",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_8076bed4",
"filename": "specs/STX_Example_Spec.rst",
"patchSetId": 2
},
"lineNbr": 172,
"author": {
"id": 9557
},
"writtenOn": "2018-10-02T14:10:19Z",
"side": 1,
"message": "Removed.",
"parentUuid": "3f79a3b5_0f898bc5",
"revId": "79a8d6abf7d4e23cf62855e592834e3c48fad5a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_efa44f4e",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_1b277fb8",
"filename": "specs/STX_Example_Spec.rst",
"patchSetId": 2
},
"lineNbr": 238,
"author": {
"id": 9557
},
"writtenOn": "2018-10-02T14:10:19Z",
"side": 1,
"message": "Tried to make it more focused on upgrades, CI/CD pipelines could be used and the STX project might not know about it.",
"parentUuid": "3f79a3b5_efa44f4e",
"revId": "79a8d6abf7d4e23cf62855e592834e3c48fad5a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_f4b18246",
@ -68,6 +122,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_80a1de3c",
"filename": "specs/STX_Example_Spec.rst",
"patchSetId": 2
},
"lineNbr": 270,
"author": {
"id": 9557
},
"writtenOn": "2018-10-02T14:10:19Z",
"side": 1,
"message": "Done",
"parentUuid": "3f79a3b5_f4b18246",
"revId": "79a8d6abf7d4e23cf62855e592834e3c48fad5a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_0f774bd3",
@ -85,6 +157,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_469d1eb9",
"filename": "specs/STX_Example_Spec.rst",
"patchSetId": 2
},
"lineNbr": 315,
"author": {
"id": 9557
},
"writtenOn": "2018-10-02T14:10:19Z",
"side": 1,
"message": "removed tempest reference for now.",
"parentUuid": "3f79a3b5_0f774bd3",
"revId": "79a8d6abf7d4e23cf62855e592834e3c48fad5a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_d4d48649",
@ -107,6 +197,30 @@
"revId": "79a8d6abf7d4e23cf62855e592834e3c48fad5a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_2636e2b5",
"filename": "specs/STX_Example_Spec.rst",
"patchSetId": 2
},
"lineNbr": 330,
"author": {
"id": 9557
},
"writtenOn": "2018-10-02T14:10:19Z",
"side": 1,
"message": "Done + added clarity",
"parentUuid": "3f79a3b5_d4d48649",
"range": {
"startLine": 330,
"startChar": 10,
"endLine": 330,
"endChar": 28
},
"revId": "79a8d6abf7d4e23cf62855e592834e3c48fad5a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}