Update patch set 10
Patch Set 10:
(11 comments)
Patch-set: 10
Attention: {"person_ident":"Gerrit User 33394 \u003c33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33394\u003e replied on the change"}
This commit is contained in:
Gerrit User 33394
Gerrit Code Review
parent
91c230062e
commit
bb96946b96
|
|
@ -17,6 +17,159 @@
|
|||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "30a66264_dff51620",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 9,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "This will result in a proper link to the Story?",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "e092d352_45409972",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 35,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "This should be moved into the Problem Description. There should be a clear 1:1 delineation between this section and the Problem Description. For example the Problem Descriptions says \"The build system only works for x86_64\" and the Proposed Change says \"Modify the build system to add the ability to build for ARM\".",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ae494d99_753d9088",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 41,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "The actual change is a bit buried here, make it clear and up front. Something like.\n\n\"Modify the StarlingX build system to add support native builds on ARM servers. The produced runtime will be validated using Ampere Altra Processor based servers.\"",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "08290855_746f1726",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 42,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "What about potential other changes:\n- documentation\n- package lists (what happens if the current list includes a package not compatible with ARM?\"\n- patches (what happens if you discover patches needed for ARM?)\n- kernel (what happens for ARM specific kernel patches? what about the .config? what about the -rt kernel?)",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "b5aa50a6_67f75eed",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 63,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "I would suggest we most likely want to see something about secure boot here.",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "3f3d1668_72751f96",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 68,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "I think a quick statement about possible impact (or none) to x86_64 is needed here.",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "11308fe6_2fb29ce6",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 73,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "Does this apply to x86_64 only? or do you expect ARM to perform on par with x86_64?",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "73c47d4a_75bfe64b",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "Will the documentation change? The current documentation and deployment just defaults to x86_64, but this will change to the deployer having to choose between one of the now two supported architectures.",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "43bb49fb_6efcf4c5",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 85,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "Again, what about ARM patches, build flags, kernel configurations? I don\u0027t think the developer impact will be restricted to what you have listed here.",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -34,6 +187,40 @@
|
|||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ce861c40_c3ae00d4",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 191,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "Ah, so you have thought of the package lists. Make sure this is mentioned in developer impact.",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c110ced5_cdd8f92e",
|
||||
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 250,
|
||||
"author": {
|
||||
"id": 33394
|
||||
},
|
||||
"writtenOn": "2023-10-05T14:14:05Z",
|
||||
"side": 1,
|
||||
"message": "Is there an impact to the repository manager? We do want both x86_64 and ARM debs to be placed into a single repository. Some words should be added around this.",
|
||||
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
|
|||
Loading…
Reference in New Issue