starlingx
/
specs
Code Issues Proposed changes

Update patch set 25 

Patch Set 25:

(1 comment)

Patch-set: 25
Attention: {"person_ident":"Gerrit User 8768 \u003c8768@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8768\u003e replied on the change"}
This commit is contained in:
Gerrit User 8768 2023-06-15 20:09:16 +00:00 committed by Gerrit Code Review
parent 0c213814cc
commit f9d371553e
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
15029b255f03d3fff587d4cf91e5b0de621dd588
View File

@ -33,6 +33,29 @@
"message": "Great work!",
"revId": "15029b255f03d3fff587d4cf91e5b0de621dd588",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "114028ab_6103f906",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010737-configurable-power-management.rst",
"patchSetId": 25
},
"lineNbr": 235,
"author": {
"id": 8768
},
"writtenOn": "2023-06-15T20:09:16Z",
"side": 1,
"message": "This no longer matches the statement from Matt in the comments for TCPG-1436 that \" Since we will be documenting the c-state and p-state overrides as part of the Power Manager, I think it is sufficient to document that the configuration will be ignored. We don\u0027t need to adjust the GUI behavior based on the condition of the Power Manager deployment state.\"\n\nThe way this spec is written now it seems to imply that we\u0027ll have semantic checks and if Kubernetes Power Management is enabled then the GUI/CLI would not let the user modify the legacy parameters.",
"range": {
"startLine": 234,
"startChar": 0,
"endLine": 235,
"endChar": 20
},
"revId": "15029b255f03d3fff587d4cf91e5b0de621dd588",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}