starlingx
/
specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 33394 <33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 3e39b9ef629a310bd0ba8d710dba2184e312159b
Attention: {"person_ident":"Gerrit User 33394 \u003c33394@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33394\u003e replied on the change"}
This commit is contained in:
Gerrit User 33394 2024-01-25 20:37:27 +00:00 committed by Gerrit Code Review
parent 15242377e9
commit fed26855bc
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
8d05288efa59f8bcf1e9230bb4e68e1abceb1268
View File

@ -104,6 +104,23 @@
"revId": "8d05288efa59f8bcf1e9230bb4e68e1abceb1268",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bf6a1de3_439a8874",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 33394
},
"writtenOn": "2024-01-25T20:37:27Z",
"side": 1,
"message": "I think the spec covers things well. As expected and the document covers we have to be concerned about kernel cmdline, /sys, /proc, and syscalls. LTP will cover lots of this as it does extensively cover syscalls via libc. The stable ABI doesn\u0027t translate to a stable API, or a stable internal ABI, so folks adding drivers may run into issues. Maybe a note should be added about this, but I am not aware of any folks adding drivers, so maybe it is overkill.",
"revId": "8d05288efa59f8bcf1e9230bb4e68e1abceb1268",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {