starlingx
/
specs
Code Issues Proposed changes
specs/f595f62e7c3bc541ba7d1e3a707...

629 lines
23 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "bcec2923_f287bdc8",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 26026
},
"writtenOn": "2023-10-05T00:46:28Z",
"side": 1,
"message": "Minor comments ... otherwise looks good.",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "30a66264_dff51620",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 9,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "This will result in a proper link to the Story?",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b8362a36_0dee54d2",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 9,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "The link definition is in line 330:\n\n.. _#2010739: https://storyboard.openstack.org/#!/story/2010739",
"parentUuid": "30a66264_dff51620",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e092d352_45409972",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 35,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "This should be moved into the Problem Description. There should be a clear 1:1 delineation between this section and the Problem Description. For example the Problem Descriptions says \"The build system only works for x86_64\" and the Proposed Change says \"Modify the build system to add the ability to build for ARM\".",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "46d4afd8_af649342",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 35,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Ack",
"parentUuid": "e092d352_45409972",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ae494d99_753d9088",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 41,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "The actual change is a bit buried here, make it clear and up front. Something like.\n\n\"Modify the StarlingX build system to add support native builds on ARM servers. The produced runtime will be validated using Ampere Altra Processor based servers.\"",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "36cb53bd_3d4b1092",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 41,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Ack",
"parentUuid": "ae494d99_753d9088",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "08290855_746f1726",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 42,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "What about potential other changes:\n- documentation\n- package lists (what happens if the current list includes a package not compatible with ARM?\"\n- patches (what happens if you discover patches needed for ARM?)\n- kernel (what happens for ARM specific kernel patches? what about the .config? what about the -rt kernel?)",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ded8256a_4e32b429",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 42,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "For the package lists, patches and configs, there are details in the \"Work Items\", so I will change like this:\n\nThe proposed change here is to extend the support to Arm64 architecture, which\nwill modify the StarlingX Debian build system to add support native builds on\nArm64 servers, modify the package lists, container images, package meta data, \nbootstrap sctips and so on to also hanle for Arm architecture, and the produced\nruntime will be validated using Ampere Altra Processor based servers.\n\nThe change will also include adding documentations of the support for Arm64\narchitecture.",
"parentUuid": "08290855_746f1726",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b5aa50a6_67f75eed",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 63,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "I would suggest we most likely want to see something about secure boot here.",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "678ee590_f13c1c05",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 63,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "I\u0027m not familiar with secure boot, and AFAIK the patches for x86 secure boot cannot be ported to Arm, which needs extra work to investigate and re-implement for Arm.\n\nI would like to separate it out to next phase or another Story/Spec to handle, which may need the developers from Arm team to contribute, so I will change this line to:\nSecure boot support will be disabled on Arm and need extra work to investigate\nand re-implement for Arm platform. \n\nAnd I will also add a work item for this:\n\nSecure boot support\n^^^^^^^^^^^^^^^^^^^\n\n* The secure boot support will be disabled in this implementation on Arm64.\n* Extra work is needed to investigate and re-implement the support for secure\n boot on Arm64 architecture (in another Story/Spec).",
"parentUuid": "b5aa50a6_67f75eed",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3f3d1668_72751f96",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 68,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "I think a quick statement about possible impact (or none) to x86_64 is needed here.",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "069df477_ccb69b05",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 68,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Thanks for reminding, I will change this to:\n* For x86_64 end user: None\n* For Arm64 end user: there will be docs for Arm64 for these new users",
"parentUuid": "3f3d1668_72751f96",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "11308fe6_2fb29ce6",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 73,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "Does this apply to x86_64 only? or do you expect ARM to perform on par with x86_64?",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3e68567c_ee1cbdd3",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 73,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "* For x86_64: None\n* For Arm64: the performance is not likely to be the same as on x86_64.",
"parentUuid": "11308fe6_2fb29ce6",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "73c47d4a_75bfe64b",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 78,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "Will the documentation change? The current documentation and deployment just defaults to x86_64, but this will change to the deployer having to choose between one of the now two supported architectures.",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3e56979a_9bfb4499",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 78,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Yes, the doc will be changed and the deployer need to choose between the two arches.",
"parentUuid": "73c47d4a_75bfe64b",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "43bb49fb_6efcf4c5",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 85,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "Again, what about ARM patches, build flags, kernel configurations? I don\u0027t think the developer impact will be restricted to what you have listed here.",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "8a0d75ba_9be28308",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 85,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Yes, the details are listed in the work items and doc (developer guide) will be updated with all the impact.\n\nI will change the statement like this:\nThe documentation for developers (developer guide) will be updated with detail\nitems of the impact, e.g. \n\n* Avoid hardcoded arch names like \u0027x86-64\u0027 or \u0027amd64\u0027 in the source codes.\n* Consider if there are any different patches or behavior for x86 and Arm.\n* Different package lists for x86 and Arm.\n* Different container image for x86 and Arm.",
"parentUuid": "43bb49fb_6efcf4c5",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "810452b7_f7acdc3a",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 147,
"author": {
"id": 26026
},
"writtenOn": "2023-10-05T00:46:28Z",
"side": 1,
"message": "I do not see a work item to investigate and support secure boot on arm64 processor ... as mentioned on LINE 63 .",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f62b5375_1bead4bb",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 147,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T06:52:01Z",
"side": 1,
"message": "Thanks for reminding, the following work item will be added:\n\nSecure boot support\n^^^^^^^^^^^^^^^^^^^\n\n* The Secure boot support will be disabled in the initial implementation.\n* Extra investigation is needed to support Secure boot on Arm64 architecture.",
"parentUuid": "810452b7_f7acdc3a",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ce861c40_c3ae00d4",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 191,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "Ah, so you have thought of the package lists. Make sure this is mentioned in developer impact.",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2ede5aa5_5c970432",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 191,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "Ack",
"parentUuid": "ce861c40_c3ae00d4",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c110ced5_cdd8f92e",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 250,
"author": {
"id": 33394
},
"writtenOn": "2023-10-05T14:14:05Z",
"side": 1,
"message": "Is there an impact to the repository manager? We do want both x86_64 and ARM debs to be placed into a single repository. Some words should be added around this.",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4a1998b5_aba9af64",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 250,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T08:37:11Z",
"side": 1,
"message": "No impact to the repo, the deb files for x86_64 and Arm are the same ones, no extra deb files will be added, all the logic to handle different arch is inside the file \"control\" and \"rules\".",
"parentUuid": "c110ced5_cdd8f92e",
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "83437923_0baae6de",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 255,
"author": {
"id": 26026
},
"writtenOn": "2023-10-05T00:46:28Z",
"side": 1,
"message": "Reword ?\nSome OpenSource container Images ...",
"range": {
"startLine": 255,
"startChar": 2,
"endLine": 255,
"endChar": 23
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a3d2a570_456b33e8",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 255,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T06:52:01Z",
"side": 1,
"message": "Ack",
"parentUuid": "83437923_0baae6de",
"range": {
"startLine": 255,
"startChar": 2,
"endLine": 255,
"endChar": 23
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fdcfdfdb_10142f0d",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 257,
"author": {
"id": 26026
},
"writtenOn": "2023-10-05T00:46:28Z",
"side": 1,
"message": "Do we know how many OpenSource container images currently used by StarlingX fall into this category of requiring an Arm64 build by StarlingX ?",
"range": {
"startLine": 256,
"startChar": 37,
"endLine": 257,
"endChar": 21
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "15ba8821_57756ffa",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 257,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T06:52:01Z",
"side": 1,
"message": "Yes, although the number may not be exact, but I know it\u0027s less than 20 and I have a list in:\nhttps://github.com/jackiehjm/stx-builds/blob/master/docs/2023_stx_on_arm_status.md#container-images-porting",
"parentUuid": "fdcfdfdb_10142f0d",
"range": {
"startLine": 256,
"startChar": 37,
"endLine": 257,
"endChar": 21
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "499f38b1_ba3b49b3",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 290,
"author": {
"id": 26026
},
"writtenOn": "2023-10-05T00:46:28Z",
"side": 1,
"message": "what does LL stand for ?\nLow Latency ? ... should spell it out at least the first time.",
"range": {
"startLine": 290,
"startChar": 9,
"endLine": 290,
"endChar": 11
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "29a08cc3_e7b15821",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 290,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T06:52:01Z",
"side": 1,
"message": "yes, will be changed to:\nAIO-SX with Low Latency(LL) on Arm64 platform",
"parentUuid": "499f38b1_ba3b49b3",
"range": {
"startLine": 290,
"startChar": 9,
"endLine": 290,
"endChar": 11
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9f968656_01c1e2c4",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 296,
"author": {
"id": 26026
},
"writtenOn": "2023-10-05T00:46:28Z",
"side": 1,
"message": "Is there really a use case for ARM for Standard and Central/SystemController of a DC, which are traditionally deployed with larger servers ?",
"range": {
"startLine": 293,
"startChar": 0,
"endLine": 296,
"endChar": 57
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "414f6eec_339d2e11",
"filename": "doc/source/specs/stx-9.0/approved/starlingx-2010739-enablement-on-Arm-platform.rst",
"patchSetId": 10
},
"lineNbr": 296,
"author": {
"id": 29042
},
"writtenOn": "2023-10-07T06:52:01Z",
"side": 1,
"message": "I\u0027m not sure, I just think Standard and DC deployment should be able to be supported for Arm as well.",
"parentUuid": "9f968656_01c1e2c4",
"range": {
"startLine": 293,
"startChar": 0,
"endLine": 296,
"endChar": 57
},
"revId": "f595f62e7c3bc541ba7d1e3a7079543df2686a69",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink