From 0fe08fac56c033beeb0c29900b1fed351aa4f114 Mon Sep 17 00:00:00 2001 From: Gerrit User 33684 <33684@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 26 Apr 2024 20:14:56 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: (5 comments) Patch-set: 4 Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33684\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 33684 \u003c33684@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33684\u003e replied on the change"} --- 9c41dea4a861f9dffa55a78537940e00807aa75c | 120 +++++++++++++++++++++++ 1 file changed, 120 insertions(+) diff --git a/9c41dea4a861f9dffa55a78537940e00807aa75c b/9c41dea4a861f9dffa55a78537940e00807aa75c index 5b522604..65a902d3 100644 --- a/9c41dea4a861f9dffa55a78537940e00807aa75c +++ b/9c41dea4a861f9dffa55a78537940e00807aa75c @@ -23,6 +23,30 @@ "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "2b147efd_d303563f", + "filename": "/COMMIT_MSG", + "patchSetId": 2 + }, + "lineNbr": 13, + "author": { + "id": 33684 + }, + "writtenOn": "2024-04-26T20:14:56Z", + "side": 1, + "message": "The deletion is not to allow the system to be rolled-back but to allow deletion of a deploy that is not complete. For the abort process this delete function should not be called but handled by the deploy abort itself.", + "parentUuid": "362d7d75_cdf04636", + "range": { + "startLine": 12, + "startChar": 36, + "endLine": 13, + "endChar": 10 + }, + "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -46,6 +70,30 @@ "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "75588d5a_63bc8482", + "filename": "/COMMIT_MSG", + "patchSetId": 2 + }, + "lineNbr": 20, + "author": { + "id": 33684 + }, + "writtenOn": "2024-04-26T20:14:56Z", + "side": 1, + "message": "Good catch, it is deleted on the code but I forgot to mention here. Thanks.", + "parentUuid": "70335652_6d7feb93", + "range": { + "startLine": 18, + "startChar": 25, + "endLine": 20, + "endChar": 37 + }, + "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -69,6 +117,30 @@ "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "b2fd6af3_b161e1c2", + "filename": "/COMMIT_MSG", + "patchSetId": 2 + }, + "lineNbr": 26, + "author": { + "id": 33684 + }, + "writtenOn": "2024-04-26T20:14:56Z", + "side": 1, + "message": "Done", + "parentUuid": "f2a90225_8b7eaad4", + "range": { + "startLine": 26, + "startChar": 6, + "endLine": 26, + "endChar": 14 + }, + "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -92,6 +164,30 @@ "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "edd63c2e_177179d7", + "filename": "software/software/software_controller.py", + "patchSetId": 2 + }, + "lineNbr": 2654, + "author": { + "id": 33684 + }, + "writtenOn": "2024-04-26T20:14:56Z", + "side": 1, + "message": "Done", + "parentUuid": "ee84d0a4_2778eb37", + "range": { + "startLine": 2654, + "startChar": 27, + "endLine": 2654, + "endChar": 105 + }, + "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -114,6 +210,30 @@ }, "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "a72e5c2a_f0e29db7", + "filename": "software/software/software_controller.py", + "patchSetId": 2 + }, + "lineNbr": 2698, + "author": { + "id": 33684 + }, + "writtenOn": "2024-04-26T20:14:56Z", + "side": 1, + "message": "Done", + "parentUuid": "741988b7_df9efc77", + "range": { + "startLine": 2698, + "startChar": 34, + "endLine": 2698, + "endChar": 38 + }, + "revId": "9c41dea4a861f9dffa55a78537940e00807aa75c", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file