starlingx
/
update
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 35748 \u003c35748@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35748\u003e replied on the change"}
This commit is contained in:
Gerrit User 35748 2024-04-29 19:43:43 +00:00 committed by Gerrit Code Review
parent 9712d077c8
commit 253dca7568
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
287b0c088630ba497898b75f664e899469b4a6bf
View File

@ -23,6 +23,30 @@
"revId": "287b0c088630ba497898b75f664e899469b4a6bf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a2acac88_ed036398",
"filename": "software/software/software_controller.py",
"patchSetId": 6
},
"lineNbr": 3067,
"author": {
"id": 35748
},
"writtenOn": "2024-04-29T19:43:43Z",
"side": 1,
"message": "from_release and to_release mostly has value, only when the deploy object does not have the attributes set it returns \u0027None\u0027\nhttps://opendev.org/starlingx/update/src/branch/master/software/software/software_controller.py#L3040",
"parentUuid": "a3b043b9_d35d821a",
"range": {
"startLine": 3067,
"startChar": 8,
"endLine": 3067,
"endChar": 19
},
"revId": "287b0c088630ba497898b75f664e899469b4a6bf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -69,6 +93,30 @@
},
"revId": "287b0c088630ba497898b75f664e899469b4a6bf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "83630a41_6c384760",
"filename": "software/software/software_controller.py",
"patchSetId": 6
},
"lineNbr": 3068,
"author": {
"id": 35748
},
"writtenOn": "2024-04-29T19:43:43Z",
"side": 1,
"message": "For upgrade either (MM.mm) MM or mm version can differ\n\u003e\u003e\u003e release\u003d\"24.03.1\"\n\u003e\u003e\u003e rel\u003dversion.Version(release)\n\u003e\u003e\u003e rel.major\n24\n\u003e\u003e\u003e rel.minor\n3\n\u003e\u003e\u003e rel.micro\n1\n\n\nCould you please provide more info on the below, as it seems to work\nfor either of the conditions.\n\n\u003e\u003e\u003e if (rel.major !\u003d to_rel.major or rel.minor !\u003d to_rel.minor):\n... print(rel.minor,to_rel.minor)\n...\n3 9",
"parentUuid": "18a62d42_1b45b59c",
"range": {
"startLine": 3068,
"startChar": 11,
"endLine": 3068,
"endChar": 94
},
"revId": "287b0c088630ba497898b75f664e899469b4a6bf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}