starlingx
/
update
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review+1

(1 comment)

Patch-set: 7
Reviewer: Gerrit User 28466 <28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 8d1e59fea99215a548c2f9f91ee83b063e094bc3
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28466 \u003c28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
This commit is contained in:
Gerrit User 28466 2024-04-25 19:01:21 +00:00 committed by Gerrit Code Review
parent 1c990eec95
commit 25ceeae313
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
d65d9f52a6b1447be87da2a137055bd210e0823e
View File

@ -50,6 +50,24 @@
"message": "please verify that this does not block patch apply before bootstrap (when FM may not be running yet)",
"revId": "d65d9f52a6b1447be87da2a137055bd210e0823e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "27cd78be_48bc1ad2",
"filename": "software/software/software_controller.py",
"patchSetId": 7
},
"lineNbr": 592,
"author": {
"id": 28466
},
"writtenOn": "2024-04-25T19:01:21Z",
"side": 1,
"message": "looks like pre-bootstrap patch install is done by \"install-local\" via install_local api as there is no controller-0 named. https://opendev.org/starlingx/update/src/branch/master/software/software/software_controller.py#L1123. In which case it does not go through messaging between software-controller-daemon and software-agent, and it is done as part of sw-patch lsb script (https://opendev.org/starlingx/update/src/branch/master/software/software/software_controller.py#L1167 yet to be moved to USM).",
"parentUuid": "e6554775_f956da77",
"revId": "d65d9f52a6b1447be87da2a137055bd210e0823e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}