From a73c869d385a864032fd19cdad0dcadfe280f5a7 Mon Sep 17 00:00:00 2001 From: Gerrit User 28466 <28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 26 Apr 2024 15:53:34 +0000 Subject: [PATCH] Update patch set 7 Patch Set 7: (7 comments) Patch-set: 7 --- c96da8ef26958fe6e07531eb7570dcb609e49ad6 | 114 +++++++++++++++++++++++ cf53bd19619c69b17e886d5e5ac651f22565a760 | 48 ++++++++++ 2 files changed, 162 insertions(+) diff --git a/c96da8ef26958fe6e07531eb7570dcb609e49ad6 b/c96da8ef26958fe6e07531eb7570dcb609e49ad6 index 9e265654..97c33b7f 100644 --- a/c96da8ef26958fe6e07531eb7570dcb609e49ad6 +++ b/c96da8ef26958fe6e07531eb7570dcb609e49ad6 @@ -23,6 +23,30 @@ "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "0f21ff87_5179e415", + "filename": "/COMMIT_MSG", + "patchSetId": 6 + }, + "lineNbr": 10, + "author": { + "id": 28466 + }, + "writtenOn": "2024-04-26T15:53:34Z", + "side": 1, + "message": "Done", + "parentUuid": "7f18d3a2_9ccc7c2e", + "range": { + "startLine": 10, + "startChar": 17, + "endLine": 10, + "endChar": 30 + }, + "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": false, "key": { @@ -86,6 +110,30 @@ "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "bf7a17ff_e6383c86", + "filename": "software-client/software_client/common/http.py", + "patchSetId": 6 + }, + "lineNbr": 180, + "author": { + "id": 28466 + }, + "writtenOn": "2024-04-26T15:53:34Z", + "side": 1, + "message": "Done", + "parentUuid": "88c5c828_c0de2ef8", + "range": { + "startLine": 180, + "startChar": 70, + "endLine": 180, + "endChar": 77 + }, + "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -132,6 +180,30 @@ "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "c11ee819_90226209", + "filename": "software/software/authapi/app.py", + "patchSetId": 6 + }, + "lineNbr": 15, + "author": { + "id": 28466 + }, + "writtenOn": "2024-04-26T15:53:34Z", + "side": 1, + "message": "Done", + "parentUuid": "5c71c3a1_b985d9ca", + "range": { + "startLine": 15, + "startChar": 0, + "endLine": 15, + "endChar": 61 + }, + "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -155,6 +227,30 @@ "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "bcf1d64e_541dad72", + "filename": "software/software/authapi/app.py", + "patchSetId": 6 + }, + "lineNbr": 59, + "author": { + "id": 28466 + }, + "writtenOn": "2024-04-26T15:53:34Z", + "side": 1, + "message": "Done", + "parentUuid": "625f9237_86db67f5", + "range": { + "startLine": 59, + "startChar": 8, + "endLine": 59, + "endChar": 43 + }, + "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -171,6 +267,24 @@ "message": "region_name as a parameter - Is it actually required by this controller which only runs in this region?", "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "b521e319_d59208f6", + "filename": "software/software/software_controller.py", + "patchSetId": 6 + }, + "lineNbr": 2226, + "author": { + "id": 28466 + }, + "writtenOn": "2024-04-26T15:53:34Z", + "side": 1, + "message": "This is not a required parameter. it is coming from the REST API. If specified, the precheck will be conducted against the specified region.", + "parentUuid": "157ebbf0_9b7c0956", + "revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file diff --git a/cf53bd19619c69b17e886d5e5ac651f22565a760 b/cf53bd19619c69b17e886d5e5ac651f22565a760 index 2b69a1f7..b71fd59f 100644 --- a/cf53bd19619c69b17e886d5e5ac651f22565a760 +++ b/cf53bd19619c69b17e886d5e5ac651f22565a760 @@ -23,6 +23,30 @@ "revId": "cf53bd19619c69b17e886d5e5ac651f22565a760", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": false, + "key": { + "uuid": "3008bac4_38adc130", + "filename": "software/scripts/deploy-precheck", + "patchSetId": 7 + }, + "lineNbr": 236, + "author": { + "id": 28466 + }, + "writtenOn": "2024-04-26T15:53:34Z", + "side": 1, + "message": "thanks for catching this. fixed.", + "parentUuid": "5a94d85c_f0159fa0", + "range": { + "startLine": 236, + "startChar": 41, + "endLine": 236, + "endChar": 47 + }, + "revId": "cf53bd19619c69b17e886d5e5ac651f22565a760", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": { @@ -45,6 +69,30 @@ }, "revId": "cf53bd19619c69b17e886d5e5ac651f22565a760", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": false, + "key": { + "uuid": "c54be323_6a0da3df", + "filename": "software/scripts/deploy-precheck", + "patchSetId": 7 + }, + "lineNbr": 245, + "author": { + "id": 28466 + }, + "writtenOn": "2024-04-26T15:53:34Z", + "side": 1, + "message": "nice catch. thanks", + "parentUuid": "3cb18207_6740f9c9", + "range": { + "startLine": 245, + "startChar": 46, + "endLine": 245, + "endChar": 52 + }, + "revId": "cf53bd19619c69b17e886d5e5ac651f22565a760", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file