starlingx
/
update
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

Patch-set: 6
Attention: {"person_ident":"Gerrit User 35148 \u003c35148@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35148\u003e replied on the change"}
This commit is contained in:
Gerrit User 35148 2024-04-29 18:13:30 +00:00 committed by Gerrit Code Review
parent 7030fb0a4f
commit c1f9bc828c
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
287b0c088630ba497898b75f664e899469b4a6bf
View File

@ -22,6 +22,29 @@
},
"revId": "287b0c088630ba497898b75f664e899469b4a6bf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5bea874b_91e74411",
"filename": "software/software/software_controller.py",
"patchSetId": 6
},
"lineNbr": 3068,
"author": {
"id": 35148
},
"writtenOn": "2024-04-29T18:13:30Z",
"side": 1,
"message": "Couple things:\n* Why is minor version checked?\n* The parentheses are not correct, should be (...) or (...)",
"range": {
"startLine": 3068,
"startChar": 11,
"endLine": 3068,
"endChar": 94
},
"revId": "287b0c088630ba497898b75f664e899469b4a6bf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}