starlingx
/
update
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(3 comments)

Patch-set: 6
This commit is contained in:
Gerrit User 9926 2024-04-25 12:56:10 +00:00 committed by Gerrit Code Review
parent f0262e7b22
commit f0d68e3056
1 changed files with 63 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
c96da8ef26958fe6e07531eb7570dcb609e49ad6
View File

@ -1,5 +1,28 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7f18d3a2_9ccc7c2e",
"filename": "/COMMIT_MSG",
"patchSetId": 6
},
"lineNbr": 10,
"author": {
"id": 9926
},
"writtenOn": "2024-04-25T12:56:10Z",
"side": 1,
"message": "nit: standardized",
"range": {
"startLine": 10,
"startChar": 17,
"endLine": 10,
"endChar": 30
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -40,6 +63,29 @@
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "88c5c828_c0de2ef8",
"filename": "software-client/software_client/common/http.py",
"patchSetId": 6
},
"lineNbr": 180,
"author": {
"id": 9926
},
"writtenOn": "2024-04-25T12:56:10Z",
"side": 1,
"message": "nit: response",
"range": {
"startLine": 180,
"startChar": 70,
"endLine": 180,
"endChar": 77
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -108,6 +154,23 @@
},
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "157ebbf0_9b7c0956",
"filename": "software/software/software_controller.py",
"patchSetId": 6
},
"lineNbr": 2226,
"author": {
"id": 9926
},
"writtenOn": "2024-04-25T12:56:10Z",
"side": 1,
"message": "region_name as a parameter - Is it actually required by this controller which only runs in this region?",
"revId": "c96da8ef26958fe6e07531eb7570dcb609e49ad6",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}