upstream/openstack/python-horizon
Enzo Candotti feb152c085 Fix incomplete pop-up message on delete Action
When an Action table is created with a 'danger' action_type and a
single handler method for a single object, the 'selection' and
'help' parameters are empty. This causes the pop-up message to be
incomplete. For example:

"You have selected: . Please confirm your selection. "

This patch fixes this behaviour by displaying the message with
the selected objects only when one or more objects are selected.
Otherwise, it only asks for confirmation.

Closes-Bug: 2000799

Test Plan:
PASS: Build python3-django-horizon package including these changes.
PASS: Test the behaviour for single delete actions. For example:
Create a patch strategy and press the "Delete" action. Verify
the following message is displayed in the pop-up message:
"Please confirm your selection. This action cannot be undone."

PASS: Test the behaviour for multiple delete actions. For example:
Upload more than one patch, select them and click on the 'Delete'
action. Verify the following message is displayed:
You have selected: "22.12_NRR_INSVC", "22.12_RESTART_FAILURE_INSVC".
Please confirm your selection. This action cannot be undone.

Signed-off-by: Enzo Candotti <enzo.candotti@windriver.com>
Change-Id: I85bc5c8155466e14a1a5fa84d54ed22032437f88
2023-01-02 20:04:36 +00:00
..
centos Fix pep8 Zuul failure 2022-11-25 13:44:16 +00:00
debian Fix incomplete pop-up message on delete Action 2023-01-02 20:04:36 +00:00