Commit Graph

997 Commits

Author SHA1 Message Date
OpenDev Sysadmins 8ec87a9254 OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
2019-04-19 19:52:39 +00:00
Al Bailey 654c05df0e The --kubernetes flag no longer has an effect.
kubernetes mode is always enabled, the flag cannot be used to
enable or disable it.

The option in the CLI will be removed completely once the wiki
and any test tools are updated.

The code that handles the "else" will also be updated in a
later commit

Story: 2004751
Task: 29756
Change-Id: I75a81ab852252ee108fefeca5682e5b1a9d7374e
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
2019-02-28 11:14:45 -06:00
Scott Little bf0aa2c78d Merge remote-tracking branch 'starlingx/master' into HEAD
Change-Id: I2f7010f28de7eca0cf3cdff2cfc35db0a092e7d4
Signed-off-by: Scott Little <scott.little@windriver.com>
2019-02-26 12:39:50 -05:00
Zuul 66f59513e7 Merge "Allow user specified registries for config_controller" into f/stein 2019-02-25 16:23:44 +00:00
Zuul 0553cfeb89 Merge "Solve the stx-openstack reapply issue on controller-1" into f/stein 2019-02-25 16:19:24 +00:00
Mingyuan Qi 03b08b9722 Allow user specified registries for config_controller
Currently docker images were pulled from public registries during
config_controller. For some users, the connection to the public
docker registry may be slow such that installing the containerized
services images may timeout or the system simply does not have
access to the public internet.

This change allows users to specify alternative public/private
registries to replace k8s.gcr.io, gcr.io, quay.io and docker.io.
Insecure registry is supported if all default registries were
replaced by one unified registry. It lowers the complexity for
those who build his own registry without internet access.

Docker doesn't support ipv6 addr as registry name, instead
hostname or domain name in ipv6 network is allowed.

Test:
AIO-SX/AIO-DX/Standard(2+2):
  Alternative public registry (ipv4/domain) with proxy
    - config_controller pass
  Private registry (ipv4/ipv6/domain) without internet
    - config_controller pass
  Default registry with/without proxy
    - config_controller pass

Story: 2004711
Task: 28742

Change-Id: I4fee3f4e0637863b9b5ef4ef556082ac75f62a1d
Signed-off-by: Mingyuan Qi <mingyuan.qi@intel.com>
(cherry picked from commit 611a68a96a)
2019-02-25 15:28:07 +00:00
Bin Qian 7471ef852b Boost sm process priority in VBox environment
There is an instance that sm claimed its main thread ran sluggish
as some critical timer run behind the scheuled timing.
The issue could prevent the sm from scheduling services.
As the result, the controller could fail to enable.

The issue was found only on vbox labs on AIO-SX, the fix is to boost
sm process priority to nice value -10 from current -2.

Closes-Bug: 1816764
Depends-On: https://review.openstack.org/638664
Change-Id: Iafa17b1c47d65cc7394552ea1c8e7a78398e4869
Signed-off-by: Bin Qian <bin.qian@windriver.com>
(cherry picked from commit a6934ac9d2)
2019-02-25 15:27:10 +00:00
Angie Wang 5e61519ac9 Solve the stx-openstack reapply issue on controller-1
After stx-openstack applied, the stx-openstack reapply shouldn't
trigger the charts reinstallation if there has no overrides changed
for charts. However, the reinstallation happens after swacting active
controller to controller-1 due to the generated images overrides on
controller-1 are different from before. The images overrides generation
requires walking through the stx-openstack charts stored under
/scratch, but charts do not exist on controller-1's /scratch as it's
an unreplicated filesystem. This causes the images overrides to differ
between controller-1 and controller-0.

This commit updates to walk through charts and get the images for
charts during application-upload, then save the images list for each
chart into the existing images file under aramda directory
/opt/platform/armada. The images file would be used for retrieving
the images for charts to generate images overrides.

Closes-Bug: 1816173
Change-Id: I4f00c3031decb063f8f126d0c837acd4dde56fc3
Signed-off-by: Angie Wang <angie.wang@windriver.com>
(cherry picked from commit cb4b30bf56)
2019-02-25 15:23:33 +00:00
Zuul 281e1f1109 Merge "Allow user specified registries for config_controller" 2019-02-25 14:23:53 +00:00
Zuul 3b5731cf75 Merge "Boost sm process priority in VBox environment" 2019-02-25 13:15:34 +00:00
Mingyuan Qi 611a68a96a Allow user specified registries for config_controller
Currently docker images were pulled from public registries during
config_controller. For some users, the connection to the public
docker registry may be slow such that installing the containerized
services images may timeout or the system simply does not have
access to the public internet.

This change allows users to specify alternative public/private
registries to replace k8s.gcr.io, gcr.io, quay.io and docker.io.
Insecure registry is supported if all default registries were
replaced by one unified registry. It lowers the complexity for
those who build his own registry without internet access.

Docker doesn't support ipv6 addr as registry name, instead
hostname or domain name in ipv6 network is allowed.

Test:
AIO-SX/AIO-DX/Standard(2+2):
  Alternative public registry (ipv4/domain) with proxy
    - config_controller pass
  Private registry (ipv4/ipv6/domain) without internet
    - config_controller pass
  Default registry with/without proxy
    - config_controller pass

Story: 2004711
Task: 28742

Change-Id: I4fee3f4e0637863b9b5ef4ef556082ac75f62a1d
Signed-off-by: Mingyuan Qi <mingyuan.qi@intel.com>
2019-02-23 10:10:07 +08:00
Angie Wang cb4b30bf56 Solve the stx-openstack reapply issue on controller-1
After stx-openstack applied, the stx-openstack reapply shouldn't
trigger the charts reinstallation if there has no overrides changed
for charts. However, the reinstallation happens after swacting active
controller to controller-1 due to the generated images overrides on
controller-1 are different from before. The images overrides generation
requires walking through the stx-openstack charts stored under
/scratch, but charts do not exist on controller-1's /scratch as it's
an unreplicated filesystem. This causes the images overrides to differ
between controller-1 and controller-0.

This commit updates to walk through charts and get the images for
charts during application-upload, then save the images list for each
chart into the existing images file under aramda directory
/opt/platform/armada. The images file would be used for retrieving
the images for charts to generate images overrides.

Closes-Bug: 1816173
Change-Id: I4f00c3031decb063f8f126d0c837acd4dde56fc3
Signed-off-by: Angie Wang <angie.wang@windriver.com>
2019-02-22 15:07:42 -05:00
Scott Little 6f44da454d Merge remote-tracking branch starlingx/master into HEAD
Change-Id: I000b28bf01976e7c44e06ddb661d9c526a10298c
Signed-off-by: Scott Little <scott.little@windriver.com>
2019-02-22 13:28:02 -05:00
Zuul 234c04aee2 Merge "Move horizon static configs to Armada manifest" 2019-02-22 16:46:49 +00:00
Kristine Bujold 5dc8934ce5 Fix improper move of gnocchi config
In the move of gnocchi static configurations from the overrides to
the Armada manifests, some configs were put in the wrong location.
This commit fixes this.

Story: 2003909
Task: 29535

Change-Id: Iac0ada67b7a7f6c44540c731fb505090362489a1
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
2019-02-22 11:04:00 -05:00
Bin Qian a6934ac9d2 Boost sm process priority in VBox environment
There is an instance that sm claimed its main thread ran sluggish
as some critical timer run behind the scheuled timing.
The issue could prevent the sm from scheduling services.
As the result, the controller could fail to enable.

The issue was found only on vbox labs on AIO-SX, the fix is to boost
sm process priority to nice value -10 from current -2.

Closes-Bug: 1816764
Depends-On: https://review.openstack.org/638664
Change-Id: Iafa17b1c47d65cc7394552ea1c8e7a78398e4869
Signed-off-by: Bin Qian <bin.qian@windriver.com>
2019-02-22 10:50:43 -05:00
Scott Little 160ec4eca9 Merge remote-tracking branch 'starlingx/master' into HEAD
Change-Id: I7041af39932e8552bd8851f09d58c0642cad5fe9
Signed-off-by: Scott Little <scott.little@windriver.com>
2019-02-21 16:50:46 -05:00
Zuul 30a73f0547 Merge "Move DNS requirement into kubernetes::master" 2019-02-21 21:48:20 +00:00
Matt Peters 52a829d180 Temporarily disable iptables restore during puppet
Docker and kubernetes add rules to iptables, which can end up
persisted in /etc/sysconfig/iptables by calls to iptables-save.
When the puppet manifest is applied during node initialization,
kubernetes is not yet running, and any related iptables rules
will fail.

This update disables the restoration of iptables rules from
previous boots, to ensure the puppet manifest does not fail
to apply due to invalid rules. However, this means that in
a DOR scenario (Dead Office Recovery, where both controllers
will be intializing at the same time), the firewall rules
will not get reapplied.

Firewall management will be moved to Calico under story 2005066,
at which point this code will be removed.

Change-Id: I43369dba34e6859088af3794de25a68571c7154c
Closes-Bug: 1815124
Signed-off-by: Don Penney <don.penney@windriver.com>
2019-02-21 14:28:17 -05:00
Kristine Bujold c611917a0d Move horizon static configs to Armada manifest
Move all horizon static configurations from the overrides to the
Armada manifest.

This is being done so we have a consistent way of managing
containerized openstack configurations. Static configurations will
be located in the Armada manifest and dynamic configuration will be
located in the overrides files.

Story: 2003909
Task: 29635

Change-Id: I4abbc0eb158304774134e2d60f2b666c0d90bbd8
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
2019-02-21 14:08:02 -05:00
Scott Little cb45f9b3bd Merge remote-tracking branch starlingx/master into HEAD
Change-Id: If60113563bcf3e31201005769471cef6aad8e90c
Signed-off-by: Scott Little <scott.little@windriver.com>
2019-02-21 13:00:17 -05:00
Erich Cordoba cba2b66e9b Move DNS requirement into kubernetes::master
This was causing a failure in computes unlock process where the
Platform::Dns class cannot be found.

Closes-bug: 1817126
Change-Id: I0a9e9b60580944a49b9672803fc05216f204b222
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
2019-02-21 11:40:18 -06:00
Don Penney 4b35404d6a Ignore error on k8s taint removal from puppet
There are cases where the kubernetes taint is not present on,
or has already been removed from, a newly configured standby
controller. This causes the taint removal command run by the
puppet manifest to fail. This failure can be safely ignored,
so the command is updated by this commit to always return
success.

Change-Id: Icdb55738e052c65a28e44582e345038b0de83c37
Closes-Bug: 1815795
Signed-off-by: Don Penney <don.penney@windriver.com>
2019-02-21 11:33:30 -05:00
Zuul dc53ff08da Merge "Update nova overrides to fix console addressing" into f/stein 2019-02-21 05:57:10 +00:00
Irina Mihai 28766a8d43 Prevent download and creation of default Cirros glance image
- downloading the Cirros image fails in glance-bootstrap if
  the hardcoded requested image is not found
- to workaround this issue, we disable the download and creation
  of the Cirros image in glance-bootstrap through the overrides
  -> this has no other impact as the image can be created after
     the chart's installation using "openstack image create"

Change-Id: I418eb236f5eceb0124eb73787fe12e2f0aa2d9e1
Closes-Bug: 1814142
Signed-off-by: Irina Mihai <irina.mihai@windriver.com>
2019-02-20 21:26:01 +00:00
Scott Little b09d0898b6 Merge remote-tracking branch starlingx/master into HEAD
Change-Id: Ib4e64858022a39a6143d51985363513ee6019a6d
Signed-off-by: Scott Little <scott.little@windriver.com>
2019-02-20 12:03:17 -05:00
Zuul 5442d321d1 Merge "retry func iconfig_update_file when host personality is None" 2019-02-20 16:10:13 +00:00
Zuul 8dc5a888c5 Merge "Move gnocchi and ceilometer static configs" 2019-02-20 15:39:52 +00:00
Zuul 972853b73a Merge "Move heat static configs to Armada manifest" 2019-02-20 15:24:42 +00:00
Zuul 240af33ab7 Merge "Pulling application image from specified registry" 2019-02-20 14:52:44 +00:00
Zuul 3a2e5acb33 Merge "Add replica settings for mariadb ingress pod" 2019-02-20 13:15:11 +00:00
SidneyAn 53b9e46615 retry func iconfig_update_file when host personality is None
when we run "system dns-modify" command, the command will response after
sysinv-db was updated, and file "/etc/resolv.conf" will be updated
asynchronously by another process "sysinv-agent". Once the attr
"_ihost_personality" of agent is None(initial value), it will not update
file "/etc/resolv.conf" and will not inform sysinv client also,
which will lead command dns-modify failed silently.

This patch will retry function iconfig_update_file by which sysinv-agent
update file "/etc/resolv.conf" when attr "_ihost_personality" is None.

Closes-bug: 1812269

Change-Id: I3a0437750a53607c04932c1b9b818e83903bb28b
Signed-off-by: SidneyAn <ran1.an@intel.com>
2019-02-20 14:46:25 +08:00
David Sullivan 1c467789c4 Add replica settings for mariadb ingress pod
There was no mariadb replica override for the ingress pod. On AIO-SX
this caused two pods to be scheduled. When anti-affinity was added to
mariadb this broke application-apply on AIO-SX.

The mariadb ingress pod replication will be set to the number of
controllers.

Change-Id: Icf3f1979720629904ca9ddcabf59e8ecfab709e5
Story: 2004520
Task: 29570
Signed-off-by: David Sullivan <david.sullivan@windriver.com>
2019-02-20 00:56:09 -05:00
Erich Cordoba ed3c63a06d Add DNS requirement for kubernetes and helm.
`helm init` is being execute before networking and DNS is properly
configured in the controller. A dependency was added to kubernetes
to setup DNS, helm manifest was updated to depend on kubernetes.

Also, the `--skip-refresh` flag was added to helm init for second
controller to avoid timeout scenarios on proxy enviroments.

Closes-Bug: 1814968

Change-Id: I65759314b3a861e7fdb428889aa5f5c1c7037661
Suggested-by: Mingyuan Qi <mingyuan.qi@intel.com>
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
2019-02-19 15:51:52 -06:00
Zuul d9edf76bf2 Merge "Enable Barbican provisioning in SM in kubernetes environment" 2019-02-19 16:35:21 +00:00
Zuul 2b3925e662 Merge "Fix configutilities and controllerconfig installs in DevStack" 2019-02-19 16:35:20 +00:00
Kristine Bujold 0ce137a99a Move gnocchi and ceilometer static configs
Move all gnocchi and ceilometer static configurations from the
overrides to the Armada manifest.

This is being done so we have a consistent way of managing
containerized openstack configurations. Static configurations will
be located in the Armada manifest and dynamic configuration will be
located in the overrides files.

Story: 2003909
Task: 29535

Change-Id: Ieab861cb1751146b70f722e70b8f89d81c0ed9a5
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
2019-02-19 11:20:11 -05:00
Kristine Bujold 99e86fc151 Move heat static configs to Armada manifest
Move all heat static configurations from the overrides to the
Armada manifest.

This is being done so we have a consistent way of managing
containerized openstack configurations. Static configurations will
be located in the Armada manifest and dynamic configuration will be
located in the overrides files.

Story: 2003909
Task: 29455

Change-Id: Ie35b1696b9fce0458db724fc8163d5d181e0768a
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
2019-02-19 11:11:55 -05:00
Alex Kozyrev 70ed5b0994 Enable Barbican provisioning in SM in kubernetes environment
Since Barbican is in charge of storing BMC passwords for MTCE now
we need it to run as a bare-metal service alongside with kubernetes.
This patch enables SM provisioning for barbican in this case.

Change-Id: Id51f679738d429e78f388b6dc42e7606ef0c41ab
Story: 2003108
Task: 27700
Signed-off-by: Alex Kozyrev <alex.kozyrev@windriver.com>
2019-02-19 14:05:38 +00:00
Mingyuan Qi 7bbd49b4dd Pulling application image from specified registry
Registries where application images pulled from during application-apply
are replaced if alternative registries are set.

The images are pulled from user specified registry and tagged to local
image tag. Local image tag will not be changed comparing to using default
registry. As a result, images pushed to local registry (192.168.204.2)
are still available as cache whatever alternative registries are set or
not.

Test:
AIO-SX/AIO-DX/Standard 2+2:
  Private registry without proxy
    - application-apply pass
  Default registry with/without proxy
    - application-apply pass

Story: 2004711
Task: 29212

Change-Id: I0cc110601e78c6adb3c6f2b747dfb6c92a0c82fd
Signed-off-by: Mingyuan Qi <mingyuan.qi@intel.com>
2019-02-17 01:34:14 +00:00
David Sullivan 0dd4b86526 Add replica and anti-affinity settings
Add anti-affinity settings to openstack pods. Add replication to
novncproxy, aodh, panko and rbd_provisioner services.

Change-Id: I8091a54cab98ff295eba6e7dd6fa76827d149b5f
Story: 2004520
Task: 29418
Signed-off-by: David Sullivan <david.sullivan@windriver.com>
2019-02-16 17:48:47 -05:00
Gerry Kopec db199ed89b Update nova overrides to fix console addressing
Use new nova helm chart config option introduced in dependent commit to
prevent nova from overriding our per host override for VM console
address.

Closes-Bug: #1815490
Depends-On: I86eb80578b23fd89b7f9643b943ee759f26a15be
Change-Id: I7617157b3b2848cbbe2d9014b900cd437ac082a6
Signed-off-by: Gerry Kopec <gerry.kopec@windriver.com>
2019-02-15 20:20:57 -05:00
Angie Wang 5b94294002 Support stx-openstack app install with the authed local registry
The functionality of local docker registry authentication will be
enabled in commit https://review.openstack.org/#/c/626355/.
However, local docker registry is currently used to pull/push images
during application apply without authentication and no credentials
passed to the kubernetes when pulling images on other nodes except
for active controller.

In order to install stx-openstack app with local docker registry that
has authentication turned on, this commit updates the following:
 1. Pass the user credentials when pulling/pushing images from local
    registry during application apply.
 2. Create a well-known registry secret "default-registry-key" which
    holds the authorization token during stx-openstack app apply and
    delete the secret during removal. The helm-toolkit is updated to
    refer to this secret in k8s openstack service account template for
    pulling images from local by kubelet. This secret is also added to
    rbd-provisioner service account as well since it is not using
    helm-toolkit to create service account.

Note: #2 is short-term solution. The long-term solution is to implement
the BP https://blueprints.launchpad.net/openstack-helm/+spec/support
-docker-registry-with-authentication-turned-on.

Story: 2002840
Task: 28945
Depends-On: https://review.openstack.org/636181
Change-Id: I015dccd12c5c7fa7a4bea74eef8d172f03b5d60e
Signed-off-by: Angie Wang <angie.wang@windriver.com>
2019-02-15 15:25:33 -05:00
Zuul e886f8d545 Merge "Move neutron static configs to Armada manifest" 2019-02-15 19:19:07 +00:00
Zuul 265f5abab0 Merge "Mitigate memory leak of sessions by disabling sudo for sriov agent" 2019-02-15 17:51:23 +00:00
Scott Little 681dd797bd Merge remote-tracking branch 'starlingx/master' into HEAD
Change-Id: I0860f2105e5a7b75066019d7373ea0a4b54064c7
Signed-off-by: Scott Little <scott.little@windriver.com>
2019-02-15 12:14:42 -05:00
Kristine Bujold d5db10f6b7 Move neutron static configs to Armada manifest
Move all neutron static configurations from the overrides to the
Armada manifest.

This is being done so we have a consistent way of managing
containerized openstack configurations. Static configurations will
be located in the Armada manifest and dynamic configuration will be
located in the overrides files.

Story: 2003909
Task: 29433

Change-Id: I5baf0bbc15912e0303955456151e69856bba0385
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
2019-02-15 11:42:47 -05:00
Dean Troyer cf23446094 Fix configutilities and controllerconfig installs in DevStack
Use the DevStack-provided functions to do the Python installations
for configutilities and controllerconfig.

Prepare the plugin setting for declaring DevStack prereqs that
is available in master's DevStack playbook.

Also do not enable all services by default. sysinv-api is disabled
in the devstack job as it does not properly start under Bionic.  We
will address this separately.

Change-Id: Ib57863526d285049b5964828e1b60bf215d25a23
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2019-02-14 16:14:30 -06:00
Alex Kozyrev ceb2ae16b7 Fix for the issue for with host-delete command failure due to a typo
Recent Barbican integration commit introduced a typo in 'ihost' variable
That leads to the host-delete command failure with the following message
"local variable 'host' referenced before assignment"

Closes-Bug: 1815942
Change-Id: If8d8dcffb7b4f1bcfb831a4b6a104c95b76e5f2f
Signed-off-by: Alex Kozyrev <alex.kozyrev@windriver.com>
2019-02-14 21:19:28 +00:00
Jim Gauld acefd544f0 Mitigate memory leak of sessions by disabling sudo for sriov agent
The sriov agent was polling devices via 'sudo ip link show',
and this resulted in a severe memory leak. The usage of 'sudo'
uses the host 'dbus-daemon', and somewhere the host does not
clean up login sessions.

Symptoms:
- gradual run out of memory until system unstable, host spontaneous
  reboot due to delay or OOM
- huge growth of kernel slab
- thousands of /sys/fs/cgroup/systemd/user.slice/user-0.slice
  session-x*.scope files with empty 'tasks', i.e., sessions
  that should have deleted
- huge latency seen with ssh and various systemd commands

The problem is mitigated by disabling 'sudo' for sriov agent, using
a helm override that configures [agent]/root_helper='' .

Testing:
- Verified that we could launch a VM with SR-IOV interface;
  VFs were able to set MAC and VLAN attributes.

Closes-Bug: 1815106

Change-Id: I0c57629c01b7407c99cc7f38b409019ab87af859
Signed-off-by: Jim Gauld <james.gauld@windriver.com>
2019-02-14 15:42:07 -05:00