- The reference to cgcs_patch was the older centos python2
location, and has now bee updated to the python3 debian
package.
- Removed 'legacy-resolver' from the pip install command.
- The basepython is now python3 and the upper-constraints
for debian and python3 are now specified.
- The older python2 to 3 conversion directives in pylint
have been removed, and only the errors that are currently
valid are being suppressed.
- The python2 vs python3 requirements are now updated to
only reflect python3.
- The zuul job for pylint specifies the debian nodeset.
- override tox constraints file to use the STX constraints
This means starlingx/root needs to be a required project
None of these changes have any runtime effect.
These changes only affect tox and zuul.
Test Plan:
PASS: tox
Story: 2010642
Task: 47916
Change-Id: I1cd8a78e5e26efc4b3d4b346749735e4de9f6016
Signed-off-by: Al Bailey <al.bailey@windriver.com>
This change will allow this repo to pass zuul now
that this has merged:
https://review.opendev.org/c/zuul/zuul-jobs/+/866943
Tox 4 deprecated whitelist_externals.
Replace whitelist_externals with allowlist_externals
Partial-Bug: #2000399
Signed-off-by: Al Bailey <al.bailey@windriver.com>
Change-Id: Ia05abf9e3a1fe3990716333fa88eb5c2b2865b10
The Zuul upper-constraints env variable declaration needed
to be added to tox.ini otherwise an older constraints
was being used which does not work with newer
versions of python.
Adding legacy-resolver to attempt to resolve dependency
issues when importing different stx client modules.
Partial-Bug: #1997255
Signed-off-by: Al Bailey <al.bailey@windriver.com>
Change-Id: I88b779138aa3b19aca57e8f03f3c17ec077e7d58
flake8 2.5.5 fails on ubuntu-focal zuul machines running python3.8
with the following error:
AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
The update updates the version constraint to use newer flake8.
pylint has been switched to running in python3 which has challenges
related to the new pip resolver. The correct version of Django cannot
be specified with the new resolver so the pylint errors caused
by the newer version are suppressed for now.
The docs targets for tox use their own install_command which
does not include an upper constraint.
A non ascii character was removed from the tox.ini file which
prevented running tox on some ubuntu envs.
Partial-Bug: 1895054
Signed-off-by: albailey <Al.Bailey@windriver.com>
Change-Id: Ic6a50c2ecf2a654fd883ed92fc305336741d4303
Setting up the bandit tool for the scanning of HIGH severity issues
in the python codes under Starlingx/gui folder.
Expecting this merge will enable zuul job for CI/CD of bandit scan.
Configuration files:
1. tox.ini for adding bandit environment and command.
2. test-requirements.txt for adding bandit version.
3. .zuul.yaml file for adding bandit job and configuring under
check job to run code scan every time before code commit.
Test:
Run tox -e bandit command inside the fault folder to validate the
bandit scan and result.
Story: 2007541
Task: 39683
Depends-On: https://review.opendev.org/#/c/721294/
Change-Id: I155c9f894f8b1d701f2c75e3e892e6b83a35b11e
Signed-off-by: Sharath Kumar K <sharath.kumar@intel.com>
The starlingx-staging repo was incorrectly being pointed at for tox
pylint dependencies. The dependencies were colliding with
dependencies from other repos.
That repo is not used anymore, instead the latest stable stein is used.
This change points at the most recently released stable/stein horizon
(15.0.2) in the requirements.
This change has no effect on build or deployment, only tox.
The upper constraints zuul job overrides the stein upper constraints,
and therefore the oslo concurrency 4.0.0 released Feb 3rd is no
longer triggering a failed tox job.
Closes-Bug: 1861932
Change-Id: I3c3fd22993faf47c7e3c32bae18a7f2ab1dd031c
Signed-off-by: albailey <Al.Bailey@windriver.com>
keyring is required by sysinv, however the upper-constraints were
not being used in stx-gui, so it was pulling in a version of
keyring that is incompatible with the STX env.
This aligns the stx-gui upper constraints to be the same as the
other platform components.
Change-Id: I2d4a2f7a61c65e2753d376865e9112aa93948a35
Related-Bug: 1848786
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Changing zuul to use a different path to distcloud-client than
in developer environments.
Change-Id: I90e5da2bb2f3ee15e4600fb281b19f6982fc50b1
Signed-off-by: Tyler Smith <tyler.smith@windriver.com>
The cephclient was moved from integ to utilities.
The required projects in zuul are now alphabetized.
Change-Id: I5f52d3a4de8a5b7c617d14d98bb57519fafea4a1
Story: 2006166
Task: 36491
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
Flake8 currently ignores the following bugbear errors:
B005: Using .strip() with multi-character strings misleads the reader
B301: Python 3 does not include `.iter*` methods on dictionaries.
Enable them for more thorough testing of code
Change-Id: I34da4ac5d107e89b26828d53c84fa2167143b1e7
Story: 2004515
Task: 30241
Signed-off-by: Eric Barrett <eric.barrett@windriver.com>
Add a new tab to the system information panel. The new tab displays the
state of the controller services. This code was previously included in
the stx-upstream horizon repo.
Story: 2004552
Task: 30242
Change-Id: I223c60c18de782c637d0b67bad9b8dcfe71fd184
Signed-off-by: David Sullivan <david.sullivan@windriver.com>
The wrs_pci and wrs_providernet python files do
not exist in novaclient.
This change removes those imports.
The GUI code that is processing the results from
those imports is not currently been removed, as it may be
used by upcoming enhancements to sysinv.
Story: 2004751
Task: 29357
Change-Id: I39dfbdf60d9de008072253f1074fb2ee5c61df72
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: Ib2cae95f16f9cc646f2567b62d994824d0546c16
Baseline changes to comply with Release Notes Management
based in Reno [0]:
* Use build-openstack-releasenotes job for release notes
(We can't use the OpenStack releasenotes template as it includes
publish jobs, stx needs its own)
* Add newnote tox environment as convenience for creating new release
notes, re-using the releasenotes venv.
[0] https://docs.openstack.org/reno/latest/
Story: 2003101
Task: 26717
Change-Id: I03c426c9a493541a6b0be699bce59c69b3a6f3c3
Signed-off-by: Abraham Arce <abraham.arce.moreno@intel.com>
Fix bashate and yamllint to only run if files are provided
Story: 2003364
Task: 24419
Change-Id: If78c2c11e6db353dfee4759d6db1d7526225b1f8
Signed-off-by: Lachlan Plant <lachlan.plant@windriver.com>
Al Bailey