starlingx
/
integ
Code Issues Proposed changes
2,237 Commits 23 Branches 10 Tags 51 MiB
Commit Graph

5 Commits

Author SHA1 Message Date
Leonardo Fagundes Luz Serrano 5e19b07ebb tox: fixed warnings 
meta_data files:
- "too few spaces before comment" warning
- missing document start "---" warning

tox.ini:
- allowlist bash for testenv
- moved 'basepython' var to testenv as it was repeated
  in all derived envs
- removed "tox < 4" requirement. changed minversion to 4

pylint:
- renamed pylintrc to the standard convention ".pylintrc"
- Removed "enable" section, as all warnings are enabled by default
- Updated "disable" section as some warnings changed names
- files-output deprecated [1]
- bad-functions requires a plugin [2, 3]
- max-branchs ==> max-branches [4]
- overgeneral-exceptions updated

[1] https://pylint.pycqa.org/en/latest/whatsnew/1/1.7/summary.html#removed-changes
[2] https://pylint.pycqa.org/en/latest/user_guide/configuration/all-options.html#bad-functions
[3] https://pylint.pycqa.org/en/latest/user_guide/messages/warning/bad-builtin.html
[4] https://pylint.readthedocs.io/en/latest/user_guide/messages/refactor/too-many-branches.html

Test Plan:
pass: run tox

Partial-Bug: 1976377

Change-Id: I715ed859e046a90cc7ec5d047d42902a51009eb8
Signed-off-by: Leonardo Fagundes Luz Serrano <Leonardo.FagundesLuzSerrano@windriver.com>
 2023-09-06 17:54:55 -03:00
albailey 6420975496 Updating the pylint tox target to reflect its targets 
pylint is currently only running on storage_topology
however it was using generic dependencies and installing
and suppressing far more than it needed to.

This will get pylint to pass zuul as well, since some
of the un-needed dependencies are failing to install.

Story: 2008943
Task: 43850
Signed-off-by: albailey <Al.Bailey@windriver.com>
Change-Id: I250754ca8f4f904a902f6cfd6597fde54d1597a9
 2021-11-04 10:22:24 -05:00
Bernardo Decco 3264055bfe Add pylint py3 portability checks for the integ repo 
A lot of work has gone into making sure that StarlingX is python3
compatible. To ensure future compatibility, enable the python3
portability checks. Disable the checks that are raising errors.
Another set of commits will address the offending code.

Story: 2006796
Task: 43273
Signed-off-by: Bernardo Decco <bernardo.deccodesiqueira@windriver.com>
Change-Id: Ic4b51f71f1680b78b70e05785aca15150e7e5b2a
 2021-09-13 09:57:53 +00:00
Don Penney a944973da4 Filter new pylint warning W0707 
A new warning introduced in pylint 2.6, W0707 raise-missing-from, is
causing tox and zuul pylint tests to fail. This update filters the new
warning.

Change-Id: Ifa4daf575d3b993d2fe65d895e5c0cd40a0cbcae
Closes-Bug: 1893988
Signed-off-by: Don Penney <don.penney@windriver.com>
 2020-09-02 15:16:41 -04:00
Al Bailey 7fbddc4096 Adding a pylint tox and zuul job for stx-integ 
The failing pylint warnings and errors are currently
suppressed.  They will be fixed by subsequent commits.

Story: 2004515
Task: 28791
Change-Id: I93a89554bf2dfbd9d1cbd96728a7663c408a79b1
Signed-off-by: Al Bailey <Al.Bailey@windriver.com>
 2019-01-08 11:14:46 -06:00