starlingx
/
nfv
Code Issues Proposed changes

Fix destination buffer too small issue by static analyze tool 

code with strcpy is not proposed, replace with strncpy

Test:
deploy simplex system, create qcow2 file with guest-client and json-c
build and install. Use created qcow2 to create image named test, and
create flavor named test_flavor with add guest:heartbeat property in
metadata. Create instance with created image and flavor. Lanched the
instance, launch guestClient process with command such command
  '# guestClient --device /dev/virtio-port/cgcs.heart'
Check guestAgent in host file /var/log/guestAgent.log, confirm
heartbeat enabled as "controller-0 c7ee5d00-e782-4d0a-8292-7724b3afc4e9
enabled heartbeating status change to 'enabled'"

Closes-Bug: 1794908

Change-Id: Ieb774882802127cfffef1291cf1bcc7a4d6f8055
Signed-off-by: Martin Chen <haochuan.z.chen@intel.com>
This commit is contained in:
haochuan 2018-10-16 20:15:10 +08:00 committed by Martin, Chen
parent fce17d8115
commit b1cede2bed
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mtce-guest/src/guestVirtio.cpp
View File

@ -324,8 +324,10 @@ int virtio_channel_connect ( instInfo * instInfo_ptr )
struct sockaddr_un un;
un.sun_family = AF_UNIX;
strcpy(un.sun_path, buf);
len = offsetof(struct sockaddr_un, sun_path) + strlen(buf);
strncpy(un.sun_path, buf, sizeof(un.sun_path)-1);
un.sun_path[sizeof(un.sun_path)-1] = '\0';
len = offsetof(struct sockaddr_un, sun_path) + strlen(un.sun_path);
rc = connect(instInfo_ptr->chan_fd, (struct sockaddr *)&un, len);
if (rc < 0)
{