Commit Graph

8 Commits

Author SHA1 Message Date
Kristine Bujold 1ec6ba402b Remove wrs-server-group SDK Module from StarlingX
With the StarlingX move to supporting pure upstream OpenStack, the
majority of the SDK Modules are related to functionality no longer
supported. The remaining SDK Modules will be moved to StarlingX
documentation.

Story: 2005275
Task: 30205

Change-Id: Ic0365f07297f0094b46c59d0fc6a62130c681f1e
Signed-off-by: Kristine Bujold <kristine.bujold@windriver.com>
2019-03-27 14:01:52 -04:00
Yi Wang 262142c50c updates to stx-nfv devstack plugin
* Build and install guest_scale_helper. It is called by nova. So
  we don't implement start_xx and stop_xx functions in the plugin.
* Fix two minor issues in guest-comm and guest-agent Makefiles.
* Remove "make host_clean" in host-agent installation function.
* Add EXTRALDFLAGS to linker in guest-agent and mtce-guest Makefiles.

Story: 2003163
Task: 29237

Depends-On: https://review.openstack.org/639253
Change-Id: I4ab0b6d6e5c4920572ebadbb48778470ee020281
Signed-off-by: Yi Wang <yi.c.wang@intel.com>
2019-03-09 09:05:37 +08:00
Eric MacDonald e19907c7ea Fix host_agent service file permissions
Systemd expects service files to be world readable or
it prints a warning log.

This update adds the world readable attribute to the
host agent's service file to avoid the log noise.

Change-Id: I577440bb99d4b69bb868f27b830fd6073c5a79b2
Signed-off-by: Eric MacDonald <eric.macdonald@windriver.com>
2019-02-15 15:21:25 -05:00
Erich Cordoba 8ba8d69234 Standardize makefile for guest-common
Changes done:

 - Create install target in makefile.
 - Move install instructions to makefile.
 - Cleanup in specfile

Story: 2004043
Task: 27558

Change-Id: I045eb3468a6b39dd508abe13b3ee33705539e96a
Signed-off-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
2019-02-08 18:42:40 -06:00
Luis Botello be468f45a7 Improve security by avoiding buffer overflows
This patch adds compiler flags to improve the security of STX code.
Flags added:
Format string vulnerabilities:           CFLAGS="-Wformat -Wformat-security"
Compiler will treat string format warnings as errors,
so at compiling level, buffer overflow is avoided.

Story: 2004380
Task: 28808

Signed-off-by: Luis Botello  <luis.botello.ortega@intel.com>
Reviewed-by: Erich Cordoba <erich.cordoba.malibran@intel.com>
             Victor Rodriguez <vm.rod25@gmail.com>
Suggested-by: Victor Rodriguez <vm.rod25@gmail.com>
              Erich Cordoba <erich.cordoba.malibran@intel.com>

Change-Id: I7e844718e14b35893f9eeb725e32d9d7477f0d57
2019-01-09 05:46:04 -06:00
Tao Liu 397e40a89f Change compute node to worker node personality
Update misc compute references to worker

Tests Performed:
Non-containerized deployment
AIO-SX: Sanity and Nightly automated test suite
AIO-DX: Sanity and Nightly automated test suite
2+2 System: Sanity and Nightly automated test suite
2+2 System: Horizon Patch Orchestration

Kubernetes deployment:
AIO-SX: Create, delete, reboot and rebuild instances
2+2+2 System: worker nodes are unlock enable and no alarms

Story: 2004022
Task: 27013

Depends-On: https://review.openstack.org/#/c/624452/

Change-Id: I7b2de5c7202f2e86b55f5343c8d79d50e3a072a2
Signed-off-by: Tao Liu <tao.liu@windriver.com>
2018-12-14 14:15:16 -05:00
SidneyAn 9d0703d95f ensure string "null-terminated" and fix memory overwrite risk.
Description:
1. once new socket is added, "strncpy" is used to copy instance_name
from source string to dest, but it does not guarantee null terminated.
2. there is a memory overwrite risk when it get instance_name from
a file's name

Solution:
1. we bounded length of string instance_name to ensure it is
"null-terminated".
2. limit the copy length when instance_name is get

Test Case:
  1. success to build and deploy 1 controller + 1 compute (virtual)
  2. trigger memory overwrite in a debug version with some logs added.
     With origin code, "instance_name" in function "file_to_instance_name()"
is assigned to a string whose length is greater than its capacity.
     With patch code, "instance_name" has a limit assign length
and a null terminate.

Reproduce:
To trigger memory overwrite case, a socket file with super long name is
generated under "/var/lib/libvirt/qemu/" which is monitored by this software

Closes-Bug: 1794704
Signed-off-by: SidneyAn <ran1.an@intel.com>
Change-Id: Ifb97e3dc1b59ebdc23cda73731fb02dc342d0520
2018-11-16 05:18:16 +00:00
Dean Troyer 85cd488bef StarlingX open source release updates
Signed-off-by: Dean Troyer <dtroyer@gmail.com>
2018-05-31 07:36:51 -07:00