starlingx
/
config
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 28466 \u003c28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
This commit is contained in:
Gerrit User 28466 2024-05-06 17:35:12 +00:00 committed by Gerrit Code Review
parent 3db70711d5
commit 0bf7e42586
1 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
15ff90a90568c0a89a1cacf6661131055bace288
View File

@ -22,6 +22,46 @@
},
"revId": "15ff90a90568c0a89a1cacf6661131055bace288",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "92b82760_6ee8332a",
"filename": "sysinv/sysinv/sysinv/sysinv/puppet/base.py",
"patchSetId": 4
},
"lineNbr": 182,
"author": {
"id": 28466
},
"writtenOn": "2024-05-06T17:35:12Z",
"side": 1,
"message": "recommend make this line and consist with line 178. None, 0, false, \"\", [], {} all match else condition.",
"range": {
"startLine": 182,
"startChar": 15,
"endLine": 182,
"endChar": 22
},
"revId": "15ff90a90568c0a89a1cacf6661131055bace288",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "91dc489d_05b3344b",
"filename": "sysinv/sysinv/sysinv/sysinv/puppet/base.py",
"patchSetId": 4
},
"lineNbr": 194,
"author": {
"id": 28466
},
"writtenOn": "2024-05-06T17:35:12Z",
"side": 1,
"message": "same as above",
"revId": "15ff90a90568c0a89a1cacf6661131055bace288",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}