starlingx
/
config
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(2 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 36077 \u003c36077@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35446\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35446 \u003c35446@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35446\u003e replied on the change"}
This commit is contained in:
Gerrit User 35446 2024-05-06 14:41:35 +00:00 committed by Gerrit Code Review
parent 73dac2eadf
commit 16cbf32a18
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
40fbc39522b3f37c74f799a0674992ac636af8a9
View File

@ -17,6 +17,24 @@
"revId": "40fbc39522b3f37c74f799a0674992ac636af8a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "726fdfc3_d2aae222",
"filename": "sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py",
"patchSetId": 6
},
"lineNbr": 2871,
"author": {
"id": 35446
},
"writtenOn": "2024-05-06T14:41:35Z",
"side": 1,
"message": "Done",
"parentUuid": "b464e52c_910910eb",
"revId": "40fbc39522b3f37c74f799a0674992ac636af8a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "Question: Are these two TODOs by dvoicule still relevant? Just asking since now is an opportunity to update these comments and/or cleanup.",
"revId": "40fbc39522b3f37c74f799a0674992ac636af8a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "95592949_e7060e0a",
"filename": "sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py",
"patchSetId": 6
},
"lineNbr": 2947,
"author": {
"id": 35446
},
"writtenOn": "2024-05-06T14:41:35Z",
"side": 1,
"message": "I cleaned it up. I believe that calling the apply hooks here was never necessary because inside the application code developers can reuse code across apply/update hooks as needed.",
"parentUuid": "623d0d35_c8ba0db1",
"revId": "40fbc39522b3f37c74f799a0674992ac636af8a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}