starlingx
/
config
Code Issues Proposed changes

Update patch set 13 

Patch Set 13:

(5 comments)

Patch-set: 13
This commit is contained in:
Gerrit User 28464 2024-05-02 19:09:29 +00:00 committed by Gerrit Code Review
parent a25755ac52
commit 2f58b87ef9
1 changed files with 115 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

115
eac208e1b538e2de2d10fa258bc9097c747f0ac8
View File

@ -17,6 +17,52 @@
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2072c291_d919825f",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 40,
"author": {
"id": 28464
},
"writtenOn": "2024-05-02T19:09:29Z",
"side": 1,
"message": "Did you want all these ...\u0027s to line up ?",
"range": {
"startLine": 40,
"startChar": 14,
"endLine": 40,
"endChar": 20
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0af16500_bff23796",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 84,
"author": {
"id": 28464
},
"writtenOn": "2024-05-02T19:09:29Z",
"side": 1,
"message": "nit: extra space here and just below on 87",
"range": {
"startLine": 84,
"startChar": 45,
"endLine": 84,
"endChar": 46
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -40,6 +86,52 @@
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f955afbc_1c520387",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 93,
"author": {
"id": 28464
},
"writtenOn": "2024-05-02T19:09:29Z",
"side": 1,
"message": "missing {}\u0027s",
"range": {
"startLine": 93,
"startChar": 12,
"endLine": 93,
"endChar": 27
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "dcfcfe6d_746551a0",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 108,
"author": {
"id": 28464
},
"writtenOn": "2024-05-02T19:09:29Z",
"side": 1,
"message": "missing ${}\u0027s",
"range": {
"startLine": 108,
"startChar": 24,
"endLine": 108,
"endChar": 49
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -62,6 +154,29 @@
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "89fbe27b_47325a27",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 164,
"author": {
"id": 28464
},
"writtenOn": "2024-05-02T19:09:29Z",
"side": 1,
"message": "There is a lot of inconsistency in the use of \u0027{}\u0027s. Should always use them. Please review the file and add where missing.",
"range": {
"startLine": 164,
"startChar": 18,
"endLine": 164,
"endChar": 29
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}