starlingx
/
config
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(4 comments)

Patch-set: 11
Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33684\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 33684 \u003c33684@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33684\u003e replied on the change"}
This commit is contained in:
Gerrit User 33684 2024-04-26 06:16:00 +00:00 committed by Gerrit Code Review
parent a454c5e215
commit 507259337e
1 changed files with 96 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d
View File

@ -23,6 +23,30 @@
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b1a384b8_969130d6",
"filename": "controllerconfig/controllerconfig/upgrade-scripts/08-populate-ihost-sw-version-field.py",
"patchSetId": 10
},
"lineNbr": 45,
"author": {
"id": 33684
},
"writtenOn": "2024-04-26T06:16:00Z",
"side": 1,
"message": "No, it\u0027s not. Thanks for review!",
"parentUuid": "419c7f4e_3bf57ec8",
"range": {
"startLine": 44,
"startChar": 55,
"endLine": 45,
"endChar": 33
},
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -70,6 +94,30 @@
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "17d4dafe_3f05967e",
"filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/137_add_host_sw_version.py",
"patchSetId": 10
},
"lineNbr": 15,
"author": {
"id": 33684
},
"writtenOn": "2024-04-26T06:16:00Z",
"side": 1,
"message": "yes, it could.",
"parentUuid": "4bbd76ff_6812e688",
"range": {
"startLine": 15,
"startChar": 57,
"endLine": 15,
"endChar": 60
},
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -93,6 +141,30 @@
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c6dbc9e2_f9db1941",
"filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/models.py",
"patchSetId": 10
},
"lineNbr": 200,
"author": {
"id": 33684
},
"writtenOn": "2024-04-26T06:16:00Z",
"side": 1,
"message": "Done",
"parentUuid": "2e3a7bdf_380793b4",
"range": {
"startLine": 200,
"startChar": 24,
"endLine": 200,
"endChar": 35
},
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -115,6 +187,30 @@
},
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "92e45b52_1f42e695",
"filename": "sysinv/sysinv/sysinv/sysinv/tests/conductor/test_manager.py",
"patchSetId": 10
},
"lineNbr": 638,
"author": {
"id": 33684
},
"writtenOn": "2024-04-26T06:16:00Z",
"side": 1,
"message": "No, it\u0027s not. I\u0027ve set as 0.0 to be as is today but with size of 128 it could be MM.mm.pp as well.",
"parentUuid": "8c01fac7_7f2f365b",
"range": {
"startLine": 638,
"startChar": 36,
"endLine": 638,
"endChar": 41
},
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}