starlingx
/
config
Code Issues Proposed changes

Correct Log bug in sysinv conductor. 

In file kube_app.py, the class FlucCDHelper has a function
called make_fluxcd_operation.  Inside there is a LOG.error
with an invalid python string formatter.  The manifest_dir
string is missing, and this change corrects this issue.

Test Plan:
PASS: build-pkg -a &&  build-image
PASS: full AIO-SX install
PASS: run system application-upload
          /usr/local/share/applications/helm/security-profiles-operator-22.12-1.tgz
      run system application-list to validate the security
          profile application is uploaded successfully
      run system application-apply security-profiles-operator to deploy
          the application
      Last: observe the corrected log output in /var/log/sysinv.log

Closes-Bug: 2024020
Change-Id: Icfffd04309721193b71654927751b783b9c6ace2
Signed-off-by: Joshua Reed <joshua.reed@windriver.com>
This commit is contained in:
Joshua Reed 2023-06-15 11:54:46 -07:00
parent d2039c40c0
commit 50aa301e6d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py
View File

@ -3834,7 +3834,7 @@ class FluxCDHelper(object):
rc = self._cleanup_disabled_helm_releases(manifest_dir)
else:
LOG.error("Applying %s failed. Skipping helm release "
"cleanup...")
"cleanup..." % manifest_dir)
elif operation in [constants.APP_DELETE_OP, constants.APP_REMOVE_OP]:
rc = self._delete(manifest_dir)
elif operation == constants.APP_ROLLBACK_OP: