starlingx
/
config
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 35296 \u003c35296@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35296\u003e replied on the change"}
This commit is contained in:
Gerrit User 35296 2024-05-08 11:22:20 +00:00 committed by Gerrit Code Review
parent 1b7fd2895a
commit 6abcf7556e
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
ca8fb5c6fb0bdeca90304e4e95354acee002c67a
View File

@ -23,6 +23,30 @@
"revId": "ca8fb5c6fb0bdeca90304e4e95354acee002c67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3f6b1c4b_6fb940b6",
"filename": "sysinv/sysinv/sysinv/sysinv/api/controllers/v1/label.py",
"patchSetId": 2
},
"lineNbr": 1,
"author": {
"id": 35296
},
"writtenOn": "2024-05-08T11:22:20Z",
"side": 1,
"message": "Done",
"parentUuid": "17d0d4ef_41198ecd",
"range": {
"startLine": 1,
"startChar": 21,
"endLine": 1,
"endChar": 25
},
"revId": "ca8fb5c6fb0bdeca90304e4e95354acee002c67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -46,6 +70,30 @@
"revId": "ca8fb5c6fb0bdeca90304e4e95354acee002c67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e7bd6a39_d4dabea4",
"filename": "sysinv/sysinv/sysinv/sysinv/common/constants.py",
"patchSetId": 2
},
"lineNbr": 2124,
"author": {
"id": 35296
},
"writtenOn": "2024-05-08T11:22:20Z",
"side": 1,
"message": "According to the document it should be \u0027None\u0027 and \u0027Static\u0027. Please refer https://kubernetes.io/docs/tasks/administer-cluster/memory-manager/#memory-manager-configuration . Also I have tried using lower case, it throws below error.\n\ncontroller-0 kubelet[16170]: info E0502 08:33:47.713870 16170 run.go:74] \"command failed\" err\u003d\"failed to run Kubelet: unknown policy: \\\"static\\\"\"",
"parentUuid": "f07e1f35_1fd080f5",
"range": {
"startLine": 2124,
"startChar": 0,
"endLine": 2124,
"endChar": 26
},
"revId": "ca8fb5c6fb0bdeca90304e4e95354acee002c67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +116,30 @@
},
"revId": "ca8fb5c6fb0bdeca90304e4e95354acee002c67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e1db3478_4a37c07e",
"filename": "sysinv/sysinv/sysinv/sysinv/puppet/kubernetes.py",
"patchSetId": 2
},
"lineNbr": 2,
"author": {
"id": 35296
},
"writtenOn": "2024-05-08T11:22:20Z",
"side": 1,
"message": "Done",
"parentUuid": "36edd7bd_ba6d7e06",
"range": {
"startLine": 2,
"startChar": 21,
"endLine": 2,
"endChar": 25
},
"revId": "ca8fb5c6fb0bdeca90304e4e95354acee002c67a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}