From 77f2c9ce3d16fa43c51bf73d22defc4754f292c5 Mon Sep 17 00:00:00 2001 From: dbarbosa Date: Wed, 27 Dec 2023 11:53:50 -0300 Subject: [PATCH] Fix positional argument error when running the 76 script. A new mandatory argument was added to the registry_image.list method in the cgts sysinv client breaking the contract on 76-remove-armada-if-unused.py thus resulting in a TypeError exception. This commit adds the missing parameter and fixes the error. Test Plan: PASS Build pkgs and build image PASS Upgrade SX stx-8 -> master PASS Armada removed when there are no Armada apps Closes-Bug: 2047643 Change-Id: I16a8cc4ed6c12751fc3f90c7c12499914cf6aa52 Signed-off-by: David Bastos --- .../upgrade-scripts/76-remove-armada-if-unused.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/controllerconfig/controllerconfig/upgrade-scripts/76-remove-armada-if-unused.py b/controllerconfig/controllerconfig/upgrade-scripts/76-remove-armada-if-unused.py index c8f5e3bfe8..c86e584fe7 100644 --- a/controllerconfig/controllerconfig/upgrade-scripts/76-remove-armada-if-unused.py +++ b/controllerconfig/controllerconfig/upgrade-scripts/76-remove-armada-if-unused.py @@ -312,7 +312,8 @@ def remove_docker_images(): tiller_image = None # Get image names - image_list = client.sysinv.registry_image.list() + filter_out_untagged = False + image_list = client.sysinv.registry_image.list(int(filter_out_untagged)) if not image_list: LOG.warning("Failed to remove armada docker image.") return False