starlingx
/
config
Code Issues Proposed changes

Fix flake8 error in Python2 environment 

An anti-pattern is used. In Python2 list comprehension iterator
variable value will override broader scoped variable value.

Here the value was not used further, so no runtime error existed.
Fixed the iterator variable name.

Story: 2008454
Task: 42842
Signed-off-by: Dan Voiculeasa <dan.voiculeasa@windriver.com>
Change-Id: I534f4b1194f50446481f653b08fcd4eaff872708
This commit is contained in:
Dan Voiculeasa 2021-07-15 13:59:04 +03:00
parent 3f72eac353
commit 8d2503bd2a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sysinv/sysinv/sysinv/sysinv/conductor/manager.py
View File

@ -12373,10 +12373,11 @@ class ConductorManager(service.PeriodicService):
elif not filter_active:
ordered_apps.append(app)
LOG.info("Apps reapply order: {}".format([app.name for app in ordered_apps]))
LOG.info("Apps reapply order: {}".format(
[app_.name for app_ in ordered_apps]))
if name_only:
ordered_apps = [app.name for app in ordered_apps]
ordered_apps = [app_.name for app_ in ordered_apps]
except Exception as e:
LOG.error("Error while ordering apps for reapply {}".format(str(e)))
ordered_apps = []