starlingx
/
config
Code Issues Proposed changes

Update patch set 10 

Patch Set 10:

(2 comments)

Patch-set: 10
Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 9926 \u003c9926@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"}
This commit is contained in:
Gerrit User 33390 2024-04-25 14:48:38 +00:00 committed by Gerrit Code Review
parent 0d1360a132
commit 9f8f6b4a54
1 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d
View File

@ -46,6 +46,53 @@
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7dd04d51_d486cf7c",
"filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/137_add_host_sw_version.py",
"patchSetId": 10
},
"lineNbr": 15,
"author": {
"id": 33390
},
"writtenOn": "2024-04-25T14:48:38Z",
"side": 1,
"message": "Even less, sw_version show be MM.mm.pp if I\u0027m not mistaken, so maybe 16 is enough.",
"parentUuid": "4bbd76ff_6812e688",
"range": {
"startLine": 15,
"startChar": 57,
"endLine": 15,
"endChar": 60
},
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2e3a7bdf_380793b4",
"filename": "sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/models.py",
"patchSetId": 10
},
"lineNbr": 200,
"author": {
"id": 33390
},
"writtenOn": "2024-04-25T14:48:38Z",
"side": 1,
"message": "Same comment from John about the column size applies here.",
"range": {
"startLine": 200,
"startChar": 24,
"endLine": 200,
"endChar": 35
},
"revId": "1aa8b816a0813bcc16dc1c59fd72c2ca6444d97d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {