starlingx
/
config
Code Issues Proposed changes

Merge "Enable sysinv no-value-for-parameter check in pylint"

This commit is contained in:
Zuul 2023-06-02 19:02:34 +00:00 committed by Gerrit Code Review
parent 3b39dd5b8e 1b9cff5fd8
commit a2cba775b2
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sysinv/sysinv/sysinv/pylint.rc
View File

@ -149,7 +149,6 @@ disable=
E0605, # invalid-all-format !!!
E1101, # no-member
E1111, # assignment-from-no-return
E1120, # no-value-for-parameter !!!
E1121, # too-many-function-args !!!
E1123, # unexpected-keyword-arg !!!
E1136, # unsubscriptable-object !!!
@ -160,7 +159,7 @@ disable=
output-format=text
# Tells whether to display a full report or only the messages
reports=yes
reports=no
# Python expression which should return a note less than 10 (10 is the highest
# note). You have access to the variables errors warning, statement which

2
sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/migrate_repo/versions/038_ceph_journal_ssd.py
View File

@ -38,7 +38,7 @@ def _populate_journal(migrate_engine, meta, journal, i_istor, i_idisk):
storage_items = list(i_istor.select().execute())
# Go through all the OSDs.
for osd in storage_items:
journal_insert = journal.insert()
journal_insert = journal.insert() # pylint: disable=no-value-for-parameter
# Obtain the disk on which the OSD is kept.
sel = select([i_idisk]).where(i_idisk.c.foristorid == osd['id'])

4
sysinv/sysinv/sysinv/sysinv/tests/conductor/test_manager.py
View File

@ -1048,8 +1048,8 @@ class ManagerTestCase(base.DbTestCase):
p.start().return_value = ['v1.42.2', 'v1.43.1']
self.addCleanup(p.stop)
next_versions = kubernetes.KubeOperator.kube_get_higher_patch_version('v1.41.1',
'v1.43.1')
next_versions = kubernetes.KubeOperator().kube_get_higher_patch_version('v1.41.1',
'v1.43.1')
mock_run_playbook = mock.MagicMock()
p1 = mock.patch('sysinv.common.utils.run_playbook', mock_run_playbook)
p1.start().return_value = 0