starlingx
/
config
Code Issues Proposed changes

Update patch set 13 

Patch Set 13: Code-Review-1

(2 comments)

Patch-set: 13
Reviewer: Gerrit User 28466 <28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, e425d64bd66ba69b5b5357e4338378713e0a423a
Attention: {"person_ident":"Gerrit User 28466 \u003c28466@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28466\u003e replied on the change"}
This commit is contained in:
Gerrit User 28466 2024-05-02 15:34:23 +00:00 committed by Gerrit Code Review
parent cb50c12e90
commit cf911fc9f9
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
eac208e1b538e2de2d10fa258bc9097c747f0ac8
View File

@ -16,6 +16,52 @@
"message": "Setting W-1 as this code changes are ready to review but will be not integrated in the moment.",
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "496c64a8_806bbcb6",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 90,
"author": {
"id": 28466
},
"writtenOn": "2024-05-02T15:34:23Z",
"side": 1,
"message": "should we consider a check/recover operation for the situation that the link does not exist? otherwise it is fatal and the node is unrecoverable.",
"range": {
"startLine": 84,
"startChar": 0,
"endLine": 90,
"endChar": 6
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "7aab53ef_d818def4",
"filename": "sysinv/ipsec-auth/files/ipsec-config",
"patchSetId": 13
},
"lineNbr": 118,
"author": {
"id": 28466
},
"writtenOn": "2024-05-02T15:34:23Z",
"side": 1,
"message": "This could cause a false negative. When a stop command is issued by SM and this operation fails for whatever reason, as the link is still there, the next \"stop\" operation would be considered as \"succeed\" as line 89 will return NOT_RUNNING.",
"range": {
"startLine": 115,
"startChar": 0,
"endLine": 118,
"endChar": 6
},
"revId": "eac208e1b538e2de2d10fa258bc9097c747f0ac8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}