From fdd0be52e1d4952e23ee403654c46a39cd3c5ac5 Mon Sep 17 00:00:00 2001 From: Gerrit User 33390 <33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 26 Apr 2024 13:18:29 +0000 Subject: [PATCH] Update patch set 11 Patch Set 11: (1 comment) Patch-set: 11 Attention: {"person_ident":"Gerrit User 33390 \u003c33390@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 33684 \u003c33684@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_33390\u003e replied on the change"} --- 9ce242f20e1a586a7a310339e63e386e75877ab5 | 27 ++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 9ce242f20e1a586a7a310339e63e386e75877ab5 diff --git a/9ce242f20e1a586a7a310339e63e386e75877ab5 b/9ce242f20e1a586a7a310339e63e386e75877ab5 new file mode 100644 index 0000000000..c26a93edd5 --- /dev/null +++ b/9ce242f20e1a586a7a310339e63e386e75877ab5 @@ -0,0 +1,27 @@ +{ + "comments": [ + { + "unresolved": true, + "key": { + "uuid": "fcf3649f_147da7b6", + "filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py", + "patchSetId": 11 + }, + "lineNbr": 1937, + "author": { + "id": 33390 + }, + "writtenOn": "2024-04-26T13:18:29Z", + "side": 1, + "message": "There are other places where the version is read/write from loads table, e.g. \n\nhttps://opendev.org/starlingx/config/src/commit/64021ed7dac40d3825a1001ffa42812fc5296d47/sysinv/sysinv/sysinv/sysinv/agent/manager.py#L975-L981\n\nhttps://opendev.org/starlingx/config/src/commit/64021ed7dac40d3825a1001ffa42812fc5296d47/sysinv/sysinv/sysinv/sysinv/conductor/manager.py#L2457-L2480\n\nAre these going to be addressed by another commit? If so, it\u0027s worth mentioning in the commit message.", + "range": { + "startLine": 1936, + "startChar": 12, + "endLine": 1937, + "endChar": 40 + }, + "revId": "9ce242f20e1a586a7a310339e63e386e75877ab5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + } + ] +} \ No newline at end of file