This removes the skip_update_config parameter from the
_config_apply_runtime_manifest() call when upgrading Kubernetes
control-plane. This parameter was unintentially set to True,
so this configuration step did not persist. This caused
generation of 250.001 config-out-of-date alarms during kube
upgrade.
The review that introduced the bug:
https://review.opendev.org/c/starlingx/config/+/911100
TEST PLAN:
- watch /var/log/nfv-vim.log for each orchestrated upgrade
PASS: orchestrated k8s upgrade (no faults)
- AIO-SX, AIO-DX, Standard
PASS: orchestrated k8s upgrade, with fault insertion during
control-plane upgrade first attempt
- AIO-SX
- AIO-DX (both controller-0, controller-1)
- Standard (both controller-0, controller-1)
PASS: orchestrated k8s upgrade, with fault insertion during
control-plane upgrade first and second attempt, trigger abort
- AIO-SX
- AIO-DX (first controller)
Closes-Bug: 2056326
Change-Id: I629c8133312faa5c95d06960b15d3e516e48e4cb
Signed-off-by: Jim Gauld <James.Gauld@windriver.com>