51 lines
1.8 KiB
Plaintext
51 lines
1.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fcf3649f_147da7b6",
|
|
"filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 1937,
|
|
"author": {
|
|
"id": 33390
|
|
},
|
|
"writtenOn": "2024-04-26T13:18:29Z",
|
|
"side": 1,
|
|
"message": "There are other places where the version is read/write from loads table, e.g. \n\nhttps://opendev.org/starlingx/config/src/commit/64021ed7dac40d3825a1001ffa42812fc5296d47/sysinv/sysinv/sysinv/sysinv/agent/manager.py#L975-L981\n\nhttps://opendev.org/starlingx/config/src/commit/64021ed7dac40d3825a1001ffa42812fc5296d47/sysinv/sysinv/sysinv/sysinv/conductor/manager.py#L2457-L2480\n\nAre these going to be addressed by another commit? If so, it\u0027s worth mentioning in the commit message.",
|
|
"range": {
|
|
"startLine": 1936,
|
|
"startChar": 12,
|
|
"endLine": 1937,
|
|
"endChar": 40
|
|
},
|
|
"revId": "9ce242f20e1a586a7a310339e63e386e75877ab5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "cc21139d_9062e339",
|
|
"filename": "sysinv/sysinv/sysinv/sysinv/conductor/manager.py",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 1937,
|
|
"author": {
|
|
"id": 33684
|
|
},
|
|
"writtenOn": "2024-04-26T16:30:42Z",
|
|
"side": 1,
|
|
"message": "Yes, there\u0027s some places that consumes the version from loads table. It should be handle by another commit. I\u0027ll add this info to commit message. Thanks",
|
|
"parentUuid": "fcf3649f_147da7b6",
|
|
"range": {
|
|
"startLine": 1936,
|
|
"startChar": 12,
|
|
"endLine": 1937,
|
|
"endChar": 40
|
|
},
|
|
"revId": "9ce242f20e1a586a7a310339e63e386e75877ab5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |