starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(1 comment)

Patch-set: 6
CC: Gerrit User 36476 <36476@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 36476 2024-02-27 16:41:51 +00:00 committed by Gerrit Code Review
parent fdf4a2fe9e
commit 2c11ebd836
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
59e5e58768dfedcc1fc18f8e33ab35751f9e34c2
View File

@ -16,6 +16,23 @@
"message": "recheck",
"revId": "59e5e58768dfedcc1fc18f8e33ab35751f9e34c2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "aca4657a_01bee78a",
"filename": "distributedcloud-client/dcmanagerclient/tests/v1/test_subcloud_manager.py",
"patchSetId": 6
},
"lineNbr": 94,
"author": {
"id": 36476
},
"writtenOn": "2024-02-27T16:41:51Z",
"side": 1,
"message": "Instead of make these changes in the class, which could lead to confusion when updating the test, why not just update the one from line 76 so that base.SUBCLOUD_FIELD_RESULT_LIST_WITH_PEERID adds the REGION_NAME to the list?",
"revId": "59e5e58768dfedcc1fc18f8e33ab35751f9e34c2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}