starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 14675 <14675@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 41c3a525b40971584bb30113772747a1d7ffab54
This commit is contained in:
Gerrit User 14675 2024-02-23 14:22:12 +00:00 committed by Gerrit Code Review
parent 2f87e2b33e
commit 3835eb3094
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
05f2d0e20dae6ba421746633ad522ce71009fe86 Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "61972f54_e646ad0c",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 14675
},
"writtenOn": "2024-02-23T14:22:12Z",
"side": 1,
"message": "Add region_name in subcloud show parameters",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 48
},
"revId": "05f2d0e20dae6ba421746633ad522ce71009fe86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "02635099_cb8dc893",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 14675
},
"writtenOn": "2024-02-23T14:22:12Z",
"side": 1,
"message": "Fix py39.",
"revId": "05f2d0e20dae6ba421746633ad522ce71009fe86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "6fc9b2cc_e2b4a9af",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
"patchSetId": 3
},
"lineNbr": 113,
"author": {
"id": 14675
},
"writtenOn": "2024-02-23T14:22:12Z",
"side": 1,
"message": "Do we have any cases where region_name is None? Should we validate that? In any case, use \u0027if subcloud.region_name:\u0027 to handle empty cases.",
"revId": "05f2d0e20dae6ba421746633ad522ce71009fe86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}