starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 36205 \u003c36205@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36205\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34605 \u003c34605@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36205\u003e replied on the change"}
This commit is contained in:
Gerrit User 36205 2024-02-20 19:14:05 +00:00 committed by Gerrit Code Review
parent 8bdda73feb
commit 3e636203f0
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
88cc16386e4ab7b2cc83f760c34bc62f968718c5 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "992f8c17_8d9953fe",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 17,
"author": {
"id": 36205
},
"writtenOn": "2024-02-20T19:14:05Z",
"side": 1,
"message": "Any tests for non-geo red configurations? i.e., to verify info message handled as expected (not printed) for changes in commands/v1/subcloud_manager.py",
"revId": "88cc16386e4ab7b2cc83f760c34bc62f968718c5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f27a05d1_7dba2e54",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_peer_group_manager.py",
"patchSetId": 1
},
"lineNbr": 246,
"author": {
"id": 36205
},
"writtenOn": "2024-02-20T19:14:05Z",
"side": 1,
"message": "Are we only printing _info_message when it ends with new line (\\n)? Are you essentially checking if _info_message contains a string/valid string?",
"revId": "88cc16386e4ab7b2cc83f760c34bc62f968718c5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}