starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(2 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 35185 \u003c35185@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35185\u003e replied on the change"}
This commit is contained in:
Gerrit User 35185 2024-02-23 14:45:16 +00:00 committed by Gerrit Code Review
parent 22b683d404
commit 47ef7f3fe2
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
05f2d0e20dae6ba421746633ad522ce71009fe86
View File

@ -23,6 +23,30 @@
"revId": "05f2d0e20dae6ba421746633ad522ce71009fe86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3ea04db8_2e5f84cc",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 7,
"author": {
"id": 35185
},
"writtenOn": "2024-02-23T14:45:16Z",
"side": 1,
"message": "Done",
"parentUuid": "61972f54_e646ad0c",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 48
},
"revId": "05f2d0e20dae6ba421746633ad522ce71009fe86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
@ -56,6 +80,24 @@
"message": "Do we have any cases where region_name is None? Should we validate that? In any case, use \u0027if subcloud.region_name:\u0027 to handle empty cases.",
"revId": "05f2d0e20dae6ba421746633ad522ce71009fe86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "64e2ef9e_2fc1954a",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
"patchSetId": 3
},
"lineNbr": 113,
"author": {
"id": 35185
},
"writtenOn": "2024-02-23T14:45:16Z",
"side": 1,
"message": "The data comes from the DB, the region_name shouldn\u0027t be empty, i will remove this validation",
"parentUuid": "6fc9b2cc_e2b4a9af",
"revId": "05f2d0e20dae6ba421746633ad522ce71009fe86",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}