starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(1 comment)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 34605 \u003c34605@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35230 \u003c35230@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35230\u003e replied on the change"}
This commit is contained in:
Gerrit User 35230 2024-03-07 12:50:05 +00:00 committed by Gerrit Code Review
parent d7475c406e
commit 5b076d6a32
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
015e1cbc4e251bc7ffe45b3b765f6bc4c83fa0bf Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "ef6a090e_5d55d44c",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py",
"patchSetId": 5
},
"lineNbr": 560,
"author": {
"id": 35230
},
"writtenOn": "2024-03-07T12:50:05Z",
"side": 1,
"message": "I\u0027m not sure this property getter/setter is really needed here. I\u0027m thinking it would work the same without it since the _info_message class attr is used directly in the produce_output and _get_resources functions.",
"range": {
"startLine": 554,
"startChar": 0,
"endLine": 560,
"endChar": 34
},
"revId": "015e1cbc4e251bc7ffe45b3b765f6bc4c83fa0bf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}