starlingx
/
distcloud-client
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 34605 \u003c34605@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34605\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36205 \u003c36205@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34605\u003e replied on the change"}
This commit is contained in:
Gerrit User 34605 2024-02-21 00:10:45 +00:00 committed by Gerrit Code Review
parent 69d04d0d17
commit 750b971e7c
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
88cc16386e4ab7b2cc83f760c34bc62f968718c5
View File

@ -17,6 +17,24 @@
"revId": "88cc16386e4ab7b2cc83f760c34bc62f968718c5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4d91df06_140ccd00",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 17,
"author": {
"id": 34605
},
"writtenOn": "2024-02-21T00:10:45Z",
"side": 1,
"message": "Added negative test cases.",
"parentUuid": "992f8c17_8d9953fe",
"revId": "88cc16386e4ab7b2cc83f760c34bc62f968718c5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "Are we only printing _info_message when it ends with new line (\\n)? Are you essentially checking if _info_message contains a string/valid string?",
"revId": "88cc16386e4ab7b2cc83f760c34bc62f968718c5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f3a0de65_6fc95abe",
"filename": "distributedcloud-client/dcmanagerclient/commands/v1/subcloud_peer_group_manager.py",
"patchSetId": 1
},
"lineNbr": 246,
"author": {
"id": 34605
},
"writtenOn": "2024-02-21T00:10:45Z",
"side": 1,
"message": "I don\u0027t think it\u0027s necessary, as the server-side should guarantee that the info message it returns must be a string.",
"parentUuid": "f27a05d1_7dba2e54",
"revId": "88cc16386e4ab7b2cc83f760c34bc62f968718c5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}